improve AssertSameDifferentTypesRule test coverage

Author: mhujer

tests/Rules/PHPUnit/AssertSameDifferentTypesRuleTest.php

@@ -35,9 +35,21 @@ public function testRule()
 				'Call to assertSame() with different types array<int, string> and array<int, int> will always result in test failure.',
 				14,
 			],
+			[
+				'Call to assertSame() with different types string and int will always result in test failure.',
+				16,
+			],
+			[
+				'Call to assertSame() with different types string and int will always result in test failure.',
+				17,
+			],
+			[
+				'Call to assertSame() with different types string and int will always result in test failure.',
+				18,
+			],
 			[
 				'Call to assertSame() with different types array<string> and array<int> will always result in test failure.',
-				35,
+				39,
 			],
 		]);
 	}

tests/Rules/PHPUnit/data/Foo.php

@@ -0,0 +1,13 @@
+<?php declare(strict_types = 1);
+
+namespace Dummy;
+
+class Foo
+{
+
+	public function assertSame(): string
+	{
+		return 'Hello World!';
+	}
+
+}

tests/Rules/PHPUnit/data/assert-same.php

@@ -12,6 +12,10 @@ public function testObviouslyNotSameAssertSame()
 		$this->assertSame(1, $this->returnsString());
 		$this->assertSame('1', self::returnsInt());
 		$this->assertSame(['a', 'b'], [1, 2]);
+
+		self::assertSame('1', 2); // test self
+		static::assertSame('1', 2); // test static
+		parent::assertSame('1', 2); // test parent
 	}
 
 	private function returnsString(): string
@@ -46,6 +50,19 @@ public function testLogicallyCorrectAssertSame()
 		$this->assertSame(1, self::returnsInt());
 		$this->assertSame(['a'], ['a', 1]);
 		$this->assertSame(['a', 2, 3.0], ['a', 1]);
+		self::assertSame(1, 2); // test self
+		static::assertSame(1, 2); // test static
+		parent::assertSame(1, 2); // test parent
+	}
+
+	public function testOther()
+	{
+		// assertEquals is not checked
+		$this->assertEquals('1', 1);
+
+		// only calls on \PHPUnit\Framework\TestCase are analyzed
+		$foo = new \Dummy\Foo();
+		$foo->assertSame();
 	}
 
 }