DoNotExtendNetteObjectRule: check only direct inherintance, add test, fix PHP 7.2 compatibility.

Author: xificurk

phpstan.neon

@@ -1,3 +1,7 @@
 parameters:
+	excludes_analyse:
+		- %rootDir%/../../../tests/notAutoloaded/*
+
 	ignoreErrors:
 		- '#PHPUnit_Framework_MockObject_MockObject given#'
+		- '#Access to an undefined property PHPUnit_Framework_MockObject_MockObject::\$[a-zA-Z0-9_]+#'

src/Rule/Nette/DoNotExtendNetteObjectRule.php

@@ -43,7 +43,8 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$classReflection = $this->broker->getClass($className);
-		if ($classReflection->isSubclassOf('Nette\Object')) {
+		$parentClass = $classReflection->getNativeReflection()->getParentClass();
+		if ($parentClass !== false && $parentClass->getName() === 'Nette\Object') {
 			return [
 				sprintf(
 					"Class %s extends %s - it's better to use %s trait.",

tests/Rule/Nette/DoNotExtendNetteObjectRuleTest.php

@@ -0,0 +1,55 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rule\Nette;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
+use PHPStan\Reflection\ClassReflection;
+
+class DoNotExtendNetteObjectRuleTest extends \PHPUnit\Framework\TestCase
+{
+
+	/** @var \PHPStan\Rule\Nette\DoNotExtendNetteObjectRule */
+	private $rule;
+
+	protected function setUp()
+	{
+		$broker = $this->createMock(Broker::class);
+		$broker->method('hasClass')->will($this->returnValue(true));
+		$broker->method('getClass')->will($this->returnCallback(function (string $className) {
+			$nativeReflection = new \ReflectionClass($className);
+			$classReflection = $this->createMock(ClassReflection::class);
+			$classReflection->method('getNativeReflection')->will($this->returnValue($nativeReflection));
+			return $classReflection;
+		}));
+
+		$this->rule = new DoNotExtendNetteObjectRule($broker);
+	}
+
+	public function testSmartObjectChild()
+	{
+		$scope = $this->createMock(Scope::class);
+		$node = $this->createMock(Node::class);
+		$node->namespacedName = 'PHPStan\Tests\SmartObjectChild';
+
+		$result = $this->rule->processNode($node, $scope);
+
+		$this->assertEmpty($result);
+	}
+
+	public function testNetteObjectChild()
+	{
+		if (PHP_VERSION_ID >= 70200) {
+			$this->markTestSkipped('PHP 7.2 is incompatible with Nette\Object.');
+		}
+		$scope = $this->createMock(Scope::class);
+		$node = $this->createMock(Node::class);
+		$node->namespacedName = 'PHPStan\Tests\NetteObjectChild';
+
+		$result = $this->rule->processNode($node, $scope);
+
+		$this->assertSame(['Class PHPStan\Tests\NetteObjectChild extends Nette\Object - it\'s better to use Nette\SmartObject trait.'], $result);
+	}
+
+}

tests/notAutoloaded/NetteObjectChild.php

@@ -0,0 +1,7 @@
+<?php declare(strict_types = 1);
+namespace PHPStan\Tests;
+
+class NetteObjectChild extends \Nette\Object
+{
+
+}

tests/notAutoloaded/SmartObjectChild.php

@@ -0,0 +1,9 @@
+<?php declare(strict_types = 1);
+namespace PHPStan\Tests;
+
+class SmartObjectChild
+{
+
+	use \Nette\SmartObject;
+
+}