add stub for EntityManager::getClassMetadata

Author: Khartir

src/Type/Doctrine/Query/QueryResultTypeWalker.php

@@ -244,8 +244,10 @@ public function walkPathExpression($pathExpr)
 
 			case AST\PathExpression::TYPE_SINGLE_VALUED_ASSOCIATION:
 				if (isset($class->associationMappings[$fieldName]['inherited'])) {
-					assert(is_string($class->associationMappings[$fieldName]['inherited']));
-					$class = $this->em->getClassMetadata($class->associationMappings[$fieldName]['inherited']);
+					$newClassName = $class->associationMappings[$fieldName]['inherited'];
+					assert(is_string($newClassName));
+					/** @var class-string $newClassName */
+					$class = $this->em->getClassMetadata($newClassName);
 				}
 
 				$assoc = $class->associationMappings[$fieldName];
@@ -258,9 +260,11 @@ public function walkPathExpression($pathExpr)
 
 				$joinColumn = $assoc['joinColumns'][0];
 				assert(is_array($joinColumn));
-				assert(is_string($assoc['targetEntity']));
+				$assocClassName = $assoc['targetEntity'];
+				assert(is_string($assocClassName));
+				/** @var class-string $assocClassName */
 
-				$targetClass = $this->em->getClassMetadata($assoc['targetEntity']);
+				$targetClass = $this->em->getClassMetadata($assocClassName);
 				$identifierFieldNames = $targetClass->getIdentifierFieldNames();
 
 				if (count($identifierFieldNames) !== 1) {
@@ -510,7 +514,9 @@ public function walkFunction($function)
 				$queryComp = $this->queryComponents[$dqlAlias];
 				$class = $queryComp['metadata'];
 				$assoc = $class->associationMappings[$assocField];
-				$targetClass = $this->em->getClassMetadata($assoc['targetEntity']);
+				/** @var class-string $assocClassName */
+				$assocClassName = $assoc['targetEntity'];
+				$targetClass = $this->em->getClassMetadata($assocClassName);
 
 				if ($function->fieldMapping === null) {
 					$identifierFieldNames = $targetClass->getIdentifierFieldNames();

stubs/EntityManagerInterface.stub

@@ -4,6 +4,7 @@ namespace Doctrine\ORM;
 
 use Doctrine\Persistence\ObjectManager;
 use Doctrine\Persistence\ObjectRepository;
+use Doctrine\ORM\Mapping\ClassMetadata;
 
 interface EntityManagerInterface extends ObjectManager
 {
@@ -56,4 +57,11 @@ interface EntityManagerInterface extends ObjectManager
 	 */
 	public function copy($entity, $deep = false);
 
+  /**
+   * @template T of object
+   * @phpstan-param class-string<T> $className
+   *
+   * @phpstan-return ClassMetadata<T>
+   */
+  public function getClassMetadata($className);
 }

tests/DoctrineIntegration/ORM/EntityManagerIntegrationTest.php

@@ -22,6 +22,7 @@ public function dataTopics(): array
 			['customRepositoryUsage'],
 			['queryBuilder'],
 			[$hasDbal3 ? 'dbalQueryBuilderExecuteDynamicReturnDbal3' : 'dbalQueryBuilderExecuteDynamicReturn'],
+			['getClassMetadata'],
 		];
 	}
 

tests/DoctrineIntegration/ORM/data/getClassMetadata.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace PHPStan\DoctrineIntegration\ORM\GetClassMetadata;
+
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\EntityRepository;
+use Doctrine\ORM\Mapping\ClassMetadata;
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity(repositoryClass=MyRepository::class)
+ */
+class MyEntity
+{
+	/**
+	 * @ORM\Id()
+	 * @ORM\GeneratedValue()
+	 * @ORM\Column(type="integer")
+	 *
+	 * @var int
+	 */
+	private $id;
+}
+
+/**
+ * @template T of object
+ * @template-extends EntityRepository<T>
+ */
+class IntermediateRepository extends EntityRepository
+{
+	/**
+	 * @param ClassMetadata<T> $class
+	 */
+	public function __construct(EntityManagerInterface $em, ClassMetadata $class)
+	{
+		parent::__construct($em, $class);
+	}
+}
+
+/**
+ * @extends IntermediateRepository<MyEntity>
+ */
+class MyRepository extends IntermediateRepository
+{
+
+	public function __construct(
+		EntityManagerInterface $manager
+	) {
+		parent::__construct($manager, $manager->getClassMetadata(MyEntity::class));
+	}
+}