Separate reflection provided deprecations

Author: cs278

src/Rules/Deprecations/FetchingDeprecatedConstRule.php

@@ -5,7 +5,6 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\ConstFetch;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\GlobalConstantReflection;
 use PHPStan\Reflection\ReflectionProvider;
 
 /**
@@ -44,21 +43,23 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$constantReflection = $this->reflectionProvider->getConstant($node->name, $scope);
+		$defaultMessage = 'Use of constant %s is deprecated.';
 
-		if ($this->isDeprecated($constantReflection)) {
+		if ($constantReflection->isDeprecated()->yes()) {
 			return [sprintf(
-				$this->deprecatedConstants[$constantReflection->getName()] ?? 'Use of constant %s is deprecated.',
+				$constantReflection->getDeprecatedDescription() ?? $defaultMessage,
 				$constantReflection->getName()
 			)];
 		}
 
-		return [];
-	}
+		if (isset($this->deprecatedConstants[$constantReflection->getName()])) {
+			return [sprintf(
+				$this->deprecatedConstants[$constantReflection->getName()] ?? $defaultMessage,
+				$constantReflection->getName()
+			)];
+		}
 
-	private function isDeprecated(GlobalConstantReflection $constantReflection): bool
-	{
-		return $constantReflection->isDeprecated()->yes()
-			|| isset($this->deprecatedConstants[$constantReflection->getName()]);
+		return [];
 	}
 
 }