Add deprecation check for anonymous function typehints

Author: paxal

rules.neon

@@ -14,4 +14,5 @@ rules:
 	- PHPStan\Rules\Deprecations\InheritanceOfDeprecatedInterfaceRule
 	- PHPStan\Rules\Deprecations\InstantiationOfDeprecatedClassRule
 	- PHPStan\Rules\Deprecations\TypeHintDeprecatedInClassMethodSignatureRule
+	- PHPStan\Rules\Deprecations\TypeHintDeprecatedInClosureSignatureRule
 	- PHPStan\Rules\Deprecations\UsageOfDeprecatedTraitRule

src/Rules/Deprecations/TypeHintDeprecatedInClosureSignatureRule.php

@@ -0,0 +1,70 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Deprecations;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\InClosureNode;
+use PHPStan\Node\InFunctionNode;
+use PHPStan\Reflection\ParametersAcceptor;
+
+class TypeHintDeprecatedInClosureSignatureRule implements \PHPStan\Rules\Rule
+{
+
+	/** @var DeprecatedClassHelper */
+	private $deprecatedClassHelper;
+
+	public function __construct(DeprecatedClassHelper $deprecatedClassHelper)
+	{
+		$this->deprecatedClassHelper = $deprecatedClassHelper;
+	}
+
+	public function getNodeType(): string
+	{
+		return InClosureNode::class;
+	}
+
+	/**
+	 * @param InFunctionNode $node
+	 * @param \PHPStan\Analyser\Scope $scope
+	 * @return string[] errors
+	 */
+	public function processNode(Node $node, Scope $scope): array
+	{
+		if (DeprecatedScopeHelper::isScopeDeprecated($scope)) {
+			return [];
+		}
+
+		$functionSignature = $scope->getAnonymousFunctionReflection();
+		if (!$functionSignature instanceof ParametersAcceptor) {
+			throw new \PHPStan\ShouldNotHappenException();
+		}
+
+		$errors = [];
+		foreach ($functionSignature->getParameters() as $i => $parameter) {
+			$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($parameter->getType()->getReferencedClasses());
+			foreach ($deprecatedClasses as $deprecatedClass) {
+				$errors[] = sprintf(
+					'Parameter $%s of anonymous function has typehint with deprecated %s %s%s',
+					$parameter->getName(),
+					$this->deprecatedClassHelper->getClassType($deprecatedClass),
+					$deprecatedClass->getName(),
+					$this->deprecatedClassHelper->getClassDeprecationDescription($deprecatedClass)
+				);
+			}
+		}
+
+		$deprecatedClasses = $this->deprecatedClassHelper->filterDeprecatedClasses($functionSignature->getReturnType()->getReferencedClasses());
+		foreach ($deprecatedClasses as $deprecatedClass) {
+			$errors[] = sprintf(
+				'Return type of anonymous function has typehint with deprecated %s %s%s',
+				$this->deprecatedClassHelper->getClassType($deprecatedClass),
+				$deprecatedClass->getName(),
+				$this->deprecatedClassHelper->getClassDeprecationDescription($deprecatedClass)
+			);
+		}
+
+		return $errors;
+	}
+
+}

tests/Rules/Deprecations/TypeHintDeprecatedInClosureSignatureRuleTest.php

@@ -0,0 +1,29 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Deprecations;
+
+class TypeHintDeprecatedInClosureSignatureRuleTest extends \PHPStan\Testing\RuleTestCase
+{
+
+	protected function getRule(): \PHPStan\Rules\Rule
+	{
+		$broker = $this->createBroker();
+
+		return new TypeHintDeprecatedInClosureSignatureRule(new DeprecatedClassHelper($broker));
+	}
+
+	public function test(): void
+	{
+		require_once __DIR__ . '/data/typehint-anonymous-function-deprecated-class-definition.php';
+		$this->analyse(
+			[__DIR__ . '/data/typehint-anonymous-function-deprecated-class.php'],
+			[
+				['Parameter $property of anonymous function has typehint with deprecated class TypeHintDeprecatedInClosureSignature\DeprecatedProperty.', 5],
+				['Parameter $property2 of anonymous function has typehint with deprecated interface TypeHintDeprecatedInClosureSignature\DeprecatedInterface.', 5],
+				["Parameter \$property4 of anonymous function has typehint with deprecated class TypeHintDeprecatedInClosureSignature\VerboseDeprecatedProperty:\nI'll be back", 5],
+				['Return type of anonymous function has typehint with deprecated class TypeHintDeprecatedInClosureSignature\DeprecatedProperty.', 5],
+			]
+		);
+	}
+
+}

tests/Rules/Deprecations/data/typehint-anonymous-function-deprecated-class-definition.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace TypeHintDeprecatedInClosureSignature;
+
+/**
+ * @deprecated
+ */
+class DeprecatedProperty
+{
+
+}
+
+/**
+ * @deprecated I'll be back
+ */
+class VerboseDeprecatedProperty
+{
+
+}
+
+/**
+ * @deprecated
+ */
+interface DeprecatedInterface
+{
+
+}
+
+class Property
+{
+
+}

tests/Rules/Deprecations/data/typehint-anonymous-function-deprecated-class.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace TypeHintDeprecatedInClosureSignature;
+
+$a = function (
+    DeprecatedProperty $property,
+    ?DeprecatedInterface $property2,
+    $property3,
+    VerboseDeprecatedProperty $property4,
+    string $property5
+): ?DeprecatedProperty {
+    return $property;
+};