Strict rules

Author: ondrejmirtes

composer.json

@@ -13,7 +13,9 @@
 		"phpunit/phpunit": "^6.3",
 		"slevomat/coding-standard": "^4.7.2",
 		"squizlabs/php_codesniffer": "^3.3.2",
-		"symfony/process": "^3.4 || ^4.0"
+		"symfony/process": "^3.4 || ^4.0",
+		"phpstan/extension-installer": "^1.0",
+		"phpstan/phpstan-strict-rules": "^0.12"
 	},
 	"autoload": {
 		"psr-4": {"PHPStan\\PhpDocParser\\": ["src/"]}

phpstan.neon

@@ -1,2 +1,3 @@
 parameters:
-	ignoreErrors: []
+	ignoreErrors:
+		- '#^Dynamic call to static method PHPUnit\\Framework\\Assert#'

src/Ast/PhpDoc/MethodTagValueNode.php

@@ -35,7 +35,7 @@ public function __construct(bool $isStatic, ?TypeNode $returnType, string $metho
 	public function __toString(): string
 	{
 		$static = $this->isStatic ? 'static ' : '';
-		$returnType = $this->returnType ? "{$this->returnType} " : '';
+		$returnType = $this->returnType !== null ? "{$this->returnType} " : '';
 		$parameters = implode(', ', $this->parameters);
 		$description = $this->description !== '' ? " {$this->description}" : '';
 		return "{$static}{$returnType}{$this->methodName}({$parameters}){$description}";

src/Ast/PhpDoc/MethodTagValueParameterNode.php

@@ -36,10 +36,10 @@ public function __construct(?TypeNode $type, bool $isReference, bool $isVariadic
 
 	public function __toString(): string
 	{
-		$type = $this->type ? "{$this->type} " : '';
+		$type = $this->type !== null ? "{$this->type} " : '';
 		$isReference = $this->isReference ? '&' : '';
 		$isVariadic = $this->isVariadic ? '...' : '';
-		$default = $this->defaultValue ? " = {$this->defaultValue}" : '';
+		$default = $this->defaultValue !== null ? " = {$this->defaultValue}" : '';
 		return "{$type}{$isReference}{$isVariadic}{$this->parameterName}{$default}";
 	}
 

src/Parser/TypeParser.php

@@ -108,7 +108,7 @@ private function parseNullable(TokenIterator $tokens): Ast\Type\TypeNode
 	public function parseGeneric(TokenIterator $tokens, Ast\Type\IdentifierTypeNode $baseType): Ast\Type\GenericTypeNode
 	{
 		$tokens->consumeTokenType(Lexer::TOKEN_OPEN_ANGLE_BRACKET);
-		$genericTypes[] = $this->parse($tokens);
+		$genericTypes = [$this->parse($tokens)];
 
 		while ($tokens->tryConsumeTokenType(Lexer::TOKEN_COMMA)) {
 			$genericTypes[] = $this->parse($tokens);