Analyse extractor with PHPStan

Author: ondrejmirtes

extractor/composer.json

@@ -3,6 +3,14 @@
 		"php": "^7.4 || ^8.0",
 		"symfony/console": "^6.0.0",
 		"symfony/finder": "^6.0",
-		"nikic/php-parser": "^4.10"
+		"nikic/php-parser": "^4.10",
+		"phpstan/phpstan": "^1.5",
+		"phpstan/phpstan-php-parser": "^1.1",
+		"phpstan/extension-installer": "^1.1"
+	},
+	"config": {
+		"allow-plugins": {
+			"phpstan/extension-installer": true
+		}
 	}
 }

extractor/composer.lock

@@ -34,16 +34,22 @@ public function __construct(
 		$this->printer = $printer;
 	}
 
-	protected function configure()
+	protected function configure(): void
 	{
 		$this->setName('extract');
 	}
 
 	protected function execute(InputInterface $input, OutputInterface $output): int
 	{
 		$ourStubsDir = realpath(__DIR__ . '/../stubs');
+		if ($ourStubsDir === false) {
+			throw new \LogicException('Invalid stubs path');
+		}
 		$this->clearOldStubs($ourStubsDir);
 		$srcDir = realpath(__DIR__ . '/../php-src');
+		if ($srcDir === false) {
+			throw new \LogicException('Invalid php-src path');
+		}
 		$finder = new Finder();
 		$finder->files()->in($srcDir)->name('*.stub.php')
 			->exclude('ext/skeleton');
@@ -134,6 +140,8 @@ public function enterNode(Node $node)
 				} else {
 					throw new \Exception(sprintf('Unhandled node type %s in %s on line %s.', get_class($node), $this->stubPath, $node->getLine()));
 				}
+
+				return null;
 			}
 
 			/**
@@ -146,23 +154,33 @@ public function getStmts(): array
 		};
 
 		$nodeTraverser->addVisitor($visitor);
-		$nodeTraverser->traverse($this->parser->parse(file_get_contents($stubPath)));
+
+		$stubContents = file_get_contents($stubPath);
+		if ($stubContents === false) {
+			throw new \LogicException('Could not read stub');
+		}
+		$ast = $this->parser->parse($stubContents);
+		if ($ast === null) {
+			throw new \LogicException('AST cannot be null');
+		}
+		$nodeTraverser->traverse($ast);
 
 		$stmts = $visitor->getStmts();
 		$classes = [];
 		$functions = [];
 		foreach ($stmts as $stmt) {
+			if (!$stmt instanceof Node\Stmt\Class_ && !$stmt instanceof Node\Stmt\Interface_ && !$stmt instanceof Node\Stmt\Trait_ && !$stmt instanceof Node\Stmt\Function_) {
+				throw new \Exception(sprintf('Unhandled node type %s in %s on line %s.', get_class($stmt), $stubPath, $stmt->getLine()));
+			}
 			$namespacedName = $stmt->namespacedName->toString();
 			$pathPart = 'stubs/' . dirname($relativeStubPath) . '/' . str_replace('\\', '/', $namespacedName) . '.php';
 			$targetStubPath = __DIR__ . '/../' . $pathPart;
 
 			if ($stmt instanceof Node\Stmt\Class_ || $stmt instanceof Node\Stmt\Interface_ || $stmt instanceof Node\Stmt\Trait_) {
 				$classes[strtolower($namespacedName)] = $pathPart;
 				$stmt = $this->filterClassPhpDocs($stmt);
-			} elseif ($stmt instanceof Node\Stmt\Function_) {
-				$functions[strtolower($namespacedName)] = $pathPart;
 			} else {
-				throw new \Exception(sprintf('Unhandled node type %s in %s on line %s.', get_class($stmt), $stubPath, $stmt->getLine()));
+				$functions[strtolower($namespacedName)] = $pathPart;
 			}
 
 			if (strpos($namespacedName, '\\') !== false) {
@@ -228,7 +246,7 @@ class Php8StubsMap
 {
 
 	public const CLASSES = %s;
-	
+
 	public const FUNCTIONS = %s;
 
 }

extractor/extract.php

@@ -0,0 +1,4 @@
+parameters:
+	level: 7
+	paths:
+		- extract.php