wip: error handling

Author: Greg Bowler

build.default.json

@@ -7,7 +7,17 @@
 		},
 		"execute": {
 			"command": "webpack",
-			"arguments": ["--entry","./script/script.es6", "--output-path", "./www", "--output-filename", "script.js", "--devtool", "source-map", "--mode", "production"]
+			"arguments": ["--entry","./script/script.es6", "--output-path", "./www", "--output-filename", "script.js", "--devtool", "source-map", "--mode", "development"]
+		}
+	},
+
+	"script/*sw.js": {
+		"require": {
+			"vendor/bin/sync": "*"
+		},
+		"execute": {
+			"command": "vendor/bin/sync",
+			"arguments": ["--pattern", "*sw.js", "script", "www/"]
 		}
 	},
 

composer.lock

@@ -14,7 +14,9 @@
 use Gt\DomTemplate\PlaceholderBinder;
 use Gt\DomTemplate\TableBinder;
 use Gt\DomTemplate\TemplateCollection;
+use Gt\Http\Header\ResponseHeaders;
 use Gt\Http\Request;
+use Gt\Http\Response;
 use Gt\Http\Uri;
 use Gt\ServiceContainer\Container;
 use Gt\ServiceContainer\LazyLoad;
@@ -26,6 +28,12 @@ public function __construct(
 	) {
 	}
 
+	#[LazyLoad]
+	public function loadResponseHeaders():ResponseHeaders {
+		$response = $this->container->get(Response::class);
+		return $response->headers;
+	}
+
 	#[LazyLoad]
 	public function loadDatabase():Database {
 		$dbSettings = new Settings(

src/Middleware/DefaultServiceLoader.php

@@ -0,0 +1,39 @@
+<?php
+namespace Gt\WebEngine\Middleware;
+
+use Gt\Config\Config;
+use Gt\Dom\HTMLDocument;
+use Gt\DomTemplate\DocumentBinder;
+use Gt\Http\ResponseStatusException\ResponseStatusException;
+use Gt\Http\Uri;
+use Gt\ServiceContainer\Container;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
+use Throwable;
+
+class ErrorRequestHandler extends RequestHandler {
+	public function __construct(
+		Config $config,
+		callable $finishCallback,
+		private Throwable $throwable,
+		protected Container $serviceContainer,
+	) {
+		parent::__construct($config, $finishCallback);
+	}
+
+	public function handle(
+		ServerRequestInterface $request
+	):ResponseInterface {
+		$errorCode = 500;
+		if($this->throwable instanceof ResponseStatusException) {
+			$errorCode = $this->throwable->getHttpCode();
+		}
+
+		$errorUri = new Uri("/_$errorCode");
+		$errorRequest = $request->withUri($errorUri);
+
+		$this->completeRequestHandling($errorRequest);
+		$this->response = $this->response->withStatus($errorCode);
+		return $this->response;
+	}
+}

src/Middleware/ErrorRequestHandler.php

@@ -45,11 +45,6 @@ class Lifecycle implements MiddlewareInterface {
 	private Throwable $throwable;
 
 	public function start():void {
-		set_error_handler($this->error(...), E_ALL);
-
-//		set_error_handler(function($errno, $errstr, $errfile, $errline) {
-//			throw new \Exception($errstr, $errno, 0, $errfile, $errline);
-//		}, E_WARNING);
 // The first thing that's done within the WebEngine lifecycle is start a timer.
 // This timer is only used again at the end of the call, when finish() is
 // called - at which point the entire duration of the request is logged out (and
@@ -88,16 +83,19 @@ public function start():void {
 			$response = $this->process($request, $handler);
 		}
 		catch(Throwable $throwable) {
-// TODO: $response = $this->process($request, $errorHandler)
-// There should be some sort of magical error handler created at this point,
-// but most of the refactoring of the RequestHandler::handle() function can
-// be shared to this other Handler. This kills two birds with one stone, as
-// when generating the new response, it should still have user-code executing
-// wherever possible. Question: should _common still fire? I don't think so...
-/// ... but _error should!
-			$response = $this->responseFromThrowable($throwable);
-
 			$this->throwable = $throwable;
+
+			$errorHandler = new ErrorRequestHandler(
+				ConfigFactory::createForProject(
+					getcwd(),
+					"vendor/phpgt/webengine/config.default.ini"
+				),
+				$this->finish(...),
+				$throwable,
+				$handler->getServiceContainer(),
+			);
+			$response = $this->process($request, $errorHandler);
+
 			trigger_error(
 				$throwable->getMessage(),
 				E_USER_ERROR,
@@ -150,7 +148,7 @@ public function debugOutput(
 			if(!is_null($detailName)) {
 				$detailJs .= "console.group(\"$detailName\");";
 			}
-//			$detailJs .= "console.log(`" . print_r($detail, true) . "`)";
+			$detailJs .= "console.log(`" . print_r($detail, true) . "`)";
 			if(!is_null($detailName)) {
 				$detailJs .= "console.groupEnd();";
 			}