handle globals in lifecycle (#589)

* handle globals in lifecycle

* handle globals in request handler

* handle globals in error request handler

* clone globals before passing elsewhere

Author: Greg Bowler

src/Middleware/ErrorRequestHandler.php

@@ -17,8 +17,19 @@ public function __construct(
 		callable $finishCallback,
 		private Throwable $throwable,
 		protected Container $serviceContainer,
+		protected array $getArray,
+		protected array $postArray,
+		protected array $filesArray,
+		protected array $serverArray,
 	) {
-		parent::__construct($config, $finishCallback);
+		parent::__construct(
+			$config,
+			$finishCallback,
+			$this->getArray,
+			$this->postArray,
+			$this->filesArray,
+			$this->serverArray,
+		);
 	}
 
 	public function handle(

src/Middleware/Lifecycle.php

@@ -55,14 +55,20 @@ public function start():void {
 // to any area of code will not accidentally send output to the client.
 		ob_start();
 
+		$originalGlobals = [
+			"get" => $_GET,
+			"post" => $_POST,
+			"files" => $_FILES,
+			"server" => $_SERVER,
+		];
 // A PSR-7 HTTP Request object is created from the current global state, ready
 // for processing by the Handler.
 		$requestFactory = new RequestFactory();
 		$request = $requestFactory->createServerRequestFromGlobalState(
-			$_SERVER,
-			$_FILES,
-			$_GET,
-			$_POST,
+			$originalGlobals["server"],
+			$originalGlobals["files"],
+			$originalGlobals["get"],
+			$originalGlobals["post"],
 		);
 
 // The handler is an individual component that processes a request and produces
@@ -75,6 +81,10 @@ public function start():void {
 				"vendor/phpgt/webengine/config.default.ini"
 			),
 			$this->finish(...),
+			$originalGlobals["get"],
+			$originalGlobals["post"],
+			$originalGlobals["files"],
+			$originalGlobals["server"],
 		);
 
 // The request and request handler are passed to the PSR-15 process function,
@@ -93,6 +103,10 @@ public function start():void {
 				$this->finish(...),
 				$throwable,
 				$handler->getServiceContainer(),
+				$originalGlobals["get"],
+				$originalGlobals["post"],
+				$originalGlobals["files"],
+				$originalGlobals["server"],
 			);
 			$response = $this->process($request, $errorHandler);
 

src/Middleware/RequestHandler.php

@@ -53,6 +53,10 @@ class RequestHandler implements RequestHandlerInterface {
 	public function __construct(
 		protected readonly Config $config,
 		callable $finishCallback,
+		protected array $getArray,
+		protected array $postArray,
+		protected array $filesArray,
+		protected array $serverArray,
 	) {
 		$this->finishCallback = $finishCallback;
 
@@ -96,15 +100,15 @@ protected function completeRequestHandling(
 		$this->forceTrailingSlashes($request);
 		$this->setupServiceContainer();
 
-		$input = new Input($_GET, $_POST, $_FILES);
+		$input = new Input($this->getArray, $this->postArray, $this->filesArray);
 
 		$this->serviceContainer->set(
 			$this->config,
 			$request,
 			$this->response,
 			$this->response->headers,
 			$input,
-			new ServerInfo($_SERVER),
+			new ServerInfo($this->serverArray),
 		);
 		$this->injector = new Injector($this->serviceContainer);