Fix autogenerated @Property variable names for related records (remove trailing underscore)

Author: phpfui

Tests/Fixtures/Record/Definition/Order.php

@@ -6,17 +6,17 @@
  * Autogenerated. Do not modify. Modify SQL table, then generate with \PHPFUI\ORM\Tool\Generate\CRUD class.
  *
  * @property ?int $customer_id MySQL type integer
- * @property \Tests\App\Record\Customer $customer_ related record
+ * @property \Tests\App\Record\Customer $customer related record
  * @property ?int $employee_id MySQL type integer
- * @property \Tests\App\Record\Employee $employee_ related record
+ * @property \Tests\App\Record\Employee $employee related record
  * @property ?string $notes MySQL type longtext
  * @property string $order_date MySQL type datetime
  * @property int $order_id MySQL type integer
- * @property \Tests\App\Record\Order $order_ related record
+ * @property \Tests\App\Record\Order $order related record
  * @property ?int $order_status_id MySQL type integer
- * @property \Tests\App\Record\OrderStatus $order_status_ related record
+ * @property \Tests\App\Record\OrderStatus $order_status related record
  * @property ?int $order_tax_status_id MySQL type integer
- * @property \Tests\App\Record\OrderTaxStatus $order_tax_status_ related record
+ * @property \Tests\App\Record\OrderTaxStatus $order_tax_status related record
  * @property ?string $paid_date MySQL type datetime
  * @property ?string $payment_type MySQL type varchar(50)
  * @property ?string $ship_address MySQL type longtext
@@ -27,7 +27,7 @@
  * @property ?string $ship_zip_postal_code MySQL type varchar(50)
  * @property ?string $shipped_date MySQL type datetime
  * @property ?int $shipper_id MySQL type integer
- * @property \Tests\App\Record\Shipper $shipper_ related record
+ * @property \Tests\App\Record\Shipper $shipper related record
  * @property ?float $shipping_fee MySQL type decimal(19,4)
  * @property ?float $tax_rate MySQL type double
  * @property ?float $taxes MySQL type decimal(19,4)

Tests/Fixtures/Record/Definition/OrderDetail.php

@@ -8,17 +8,17 @@
  * @property ?string $date_allocated MySQL type datetime
  * @property float $discount MySQL type double
  * @property ?int $inventory_transaction_id MySQL type integer
- * @property \Tests\App\Record\InventoryTransaction $inventory_transaction_ related record
+ * @property \Tests\App\Record\InventoryTransaction $inventory_transaction related record
  * @property int $order_detail_id MySQL type integer
- * @property \Tests\Fixtures\Record\OrderDetail $order_detail_ related record
+ * @property \Tests\Fixtures\Record\OrderDetail $order_detail related record
  * @property ?int $order_detail_status_id MySQL type integer
- * @property \Tests\Fixtures\Record\OrderDetailStatus $order_detail_status_ related record
+ * @property \Tests\Fixtures\Record\OrderDetailStatus $order_detail_status related record
  * @property int $order_id MySQL type integer
- * @property \Tests\App\Record\Order $order_ related record
+ * @property \Tests\App\Record\Order $order related record
  * @property ?int $product_id MySQL type integer
- * @property \Tests\App\Record\Product $product_ related record
+ * @property \Tests\App\Record\Product $product related record
  * @property ?int $purchase_order_id MySQL type integer
- * @property \Tests\App\Record\PurchaseOrder $purchase_order_ related record
+ * @property \Tests\App\Record\PurchaseOrder $purchase_order related record
  * @property float $quantity MySQL type decimal(18,4)
  * @property ?float $unit_price MySQL type decimal(19,4)
  */

Tests/Fixtures/Record/Definition/Product.php

@@ -13,7 +13,7 @@
  * @property ?int $minimum_reorder_quantity MySQL type integer
  * @property ?string $product_code MySQL type varchar(25)
  * @property int $product_id MySQL type integer
- * @property \Tests\App\Record\Product $product_ related record
+ * @property \Tests\App\Record\Product $product related record
  * @property ?string $product_name MySQL type varchar(50)
  * @property ?string $quantity_per_unit MySQL type varchar(50)
  * @property ?int $reorder_level MySQL type integer

src/PHPFUI/ORM/Tool/Generate/CRUD.php

@@ -217,7 +217,7 @@ private function getComment(\PHPFUI\ORM\Schema\Field $field, array &$commentedFi
 
 		if (\str_ends_with($fieldName, \PHPFUI\ORM::$idSuffix))
 			{
-			$var = \substr($fieldName, 0, \strlen($fieldName) - 2);
+			$var = \substr($fieldName, 0, \strlen($fieldName) - \strlen(\PHPFUI\ORM::$idSuffix));
 
 			if (! isset($commentedFields[$var]))
 				{