Merge pull request #178 from carusogabriel/refactoring-tests

dbu · web-flow · commit c3bbba0eb37e · 2017-12-11T08:57:07.000+01:00
Use assertNotContains
diff --git a/tests/PHPCR/Tests/Util/NodeHelperTest.php b/tests/PHPCR/Tests/Util/NodeHelperTest.php
@@ -67,7 +67,7 @@ public function testGenerateAutoNodeName($hint, $expect)
     {
         $result = NodeHelper::generateAutoNodeName($this->usedNames, $this->namespaces, 'a', $hint);
         if (true === $expect) {
-            $this->assertFalse(strpos($result, ':'));
+            $this->assertNotContains(':', $result);
         } else {
             $this->assertEquals($expect, substr($result, 0, strlen($expect)));
         }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function testGenerateAutoNodeName($hint, $expect)`
`67`	`67`	`{`
`68`	`68`	`$result = NodeHelper::generateAutoNodeName($this->usedNames, $this->namespaces, 'a', $hint);`
`69`	`69`	`if (true === $expect) {`
`70`		`- $this->assertFalse(strpos($result, ':'));`
	`70`	`+ $this->assertNotContains(':', $result);`
`71`	`71`	`} else {`
`72`	`72`	`$this->assertEquals($expect, substr($result, 0, strlen($expect)));`
`73`	`73`	`}`