Adding tests for unquoted strings in square brackets

Author: mamazu

tests/PHPCR/Tests/Util/QOM/Sql2ScannerTest.php

@@ -28,9 +28,9 @@ public function testToken()
     /**
      * @dataProvider dataTestStringTokenization
      */
-    public function testStringTokenization()
+    public function testStringTokenization(string $query)
     {
-        $scanner = new Sql2Scanner('SELECT page.* FROM [nt:unstructured] AS page WHERE name ="Hello world"');
+        $scanner = new Sql2Scanner($query);
         $expected = [
             'SELECT',
             'page',
@@ -49,7 +49,7 @@ public function testStringTokenization()
         $this->expectTokensFromScanner($scanner, $expected);
     }
 
-    public function dataTestStringTokenization()
+    public function dataTestStringTokenization(): array
     {
         $multilineQuery = <<<'SQL'
 SELECT page.* 
@@ -124,7 +124,7 @@ public function testSQLEscapedStrings2()
         $this->expectTokensFromScanner($scanner, $expected);
     }
 
-    public function testSquareBrakets()
+    public function testSquareBrackets()
     {
         $sql = 'WHERE ISSAMENODE(file, ["/home node"])';
 
@@ -144,6 +144,25 @@ public function testSquareBrakets()
         $this->expectTokensFromScanner($scanner, $expected);
     }
 
+    public function testSquareBracketsWithoutQuotes()
+    {
+        $sql = 'WHERE ISSAMENODE(file, [/home node])';
+
+        $scanner = new Sql2Scanner($sql);
+        $expected = [
+            'WHERE',
+            'ISSAMENODE',
+            '(',
+            'file',
+            ',',
+            '[/home',
+            'node]',
+            ')',
+        ];
+
+        $this->expectTokensFromScanner($scanner, $expected);
+    }
+
     public function testTokenizingWithMissingSpaces()
     {
         $sql = 'SELECT * AS"all"';