Merge pull request #203 from phpcr/cleanup-valueconverter

names and paths can contain spaces

Author: dbu

tests/PHPCR/Tests/Util/ValueConverterTest.php

@@ -74,10 +74,10 @@ public function dataConversionMatrix()
             ['test string', PropertyType::STRING, true, PropertyType::BOOLEAN],
             ['false', PropertyType::STRING, true, PropertyType::BOOLEAN],
             ['', PropertyType::STRING, false, PropertyType::BOOLEAN],
-            // TODO: check NAME may not have spaces ['test string', PropertyType::STRING, null, PropertyType::NAME],
             ['test', PropertyType::STRING, 'test', PropertyType::NAME],
-            // TODO: check PATH may not have spaces ['test string', PropertyType::STRING, null, PropertyType::PATH],
+            ['test space', PropertyType::STRING, 'test space', PropertyType::NAME],
             ['../the/node', PropertyType::STRING, '../the/node', PropertyType::PATH],
+            ['../the space/node', PropertyType::STRING, '../the space/node', PropertyType::PATH],
             ['38b7cf18-c417-477a-af0b-c1e92a290c9a', PropertyType::STRING, '38b7cf18-c417-477a-af0b-c1e92a290c9a', PropertyType::REFERENCE],
             // TODO: should we move UUIDHelper to phpcr so we can check in PropertyType? ['test string', PropertyType::STRING, null, PropertyType::REFERENCE],
             ['', PropertyType::STRING, null, PropertyType::REFERENCE],
@@ -93,9 +93,7 @@ public function dataConversionMatrix()
             [$stream, PropertyType::BINARY, null, PropertyType::DATE],
             [$dateStream, PropertyType::BINARY, new DateTime('17.12.2010 GMT'), PropertyType::DATE],
             [$stream, PropertyType::BINARY, true, PropertyType::BOOLEAN],
-            // TODO: check NAME may not have spaces [$stream, PropertyType::BINARY, null, PropertyType::NAME],
             [$nameStream, PropertyType::BINARY, 'test', PropertyType::NAME],
-            // TODO: check PATH may not have spaces [$stream, PropertyType::BINARY, null, PropertyType::PATH],
             // TODO: should we move UUIDHelper to phpcr so we can check in PropertyType? [$stream, PropertyType::STRING, null, PropertyType::REFERENCE],
             [$uuidStream, PropertyType::BINARY, '38b7cf18-c417-477a-af0b-c1e92a290c9a', PropertyType::REFERENCE],
             [$stream, PropertyType::BINARY, 'test string', PropertyType::DECIMAL], // up to the decimal functions to validate