Removed TableHelper clone keyword

- Replaced TableHelper with a factory

Author: dantleech

CHANGELOG.md

@@ -1,6 +1,11 @@
 Changelog
 =========
 
+alpha-4
+-------
+
+- [query] Always show path next to resultset
+
 alpha-3
 -------
 

src/PHPCR/Shell/Console/Application/ShellApplication.php

@@ -30,6 +30,7 @@
 use PHPCR\Shell\Config\Profile;
 use PHPCR\Shell\Transport\TransportRegistry;
 use PHPCR\Shell\Config\ProfileLoader;
+use PHPCR\Shell\Console\Helper\TableHelper;
 
 /**
  * Main application for PHPCRSH
@@ -130,7 +131,8 @@ private function registerHelpers()
             new RepositoryHelper($phpcrHelper),
             new ResultFormatterHelper(),
             new TextHelper(),
-            $phpcrHelper,
+            new TableHelper(),
+            $phpcrHelper
         );
 
         foreach ($helpers as $helper) {

src/PHPCR/Shell/Console/Command/Phpcr/AccessControlPrivilegeListCommand.php

@@ -62,7 +62,7 @@ public function execute(InputInterface $input, OutputInterface $output)
             $privileges = $acm->getPrivileges($absPath);
         }
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
         $table->setHeaders(array('Name'));
 
         foreach ($privileges as $privilege) {

src/PHPCR/Shell/Console/Command/Phpcr/LockInfoCommand.php

@@ -47,7 +47,7 @@ public function execute(InputInterface $input, OutputInterface $output)
             'Session scoped?' => $lock->isSessionScoped() ? 'yes' : 'no',
         );
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
 
         foreach ($info as $label => $value) {
             $table->addRow(array($label, $value));

src/PHPCR/Shell/Console/Command/Phpcr/LockTokenListCommand.php

@@ -33,7 +33,7 @@ public function execute(InputInterface $input, OutputInterface $output)
 
         $lockTokens = $lockManager->getLockTokens();
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
         $table->setHeaders(array('Token'));
 
         foreach ($lockTokens as $token) {

src/PHPCR/Shell/Console/Command/Phpcr/NodeInfoCommand.php

@@ -61,7 +61,7 @@ public function execute(InputInterface $input, OutputInterface $output)
             'Locked?' => $isLocked,
         );
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
 
         foreach ($info as $label => $value) {
             $table->addRow(array($label, $value));

src/PHPCR/Shell/Console/Command/Phpcr/NodeListCommand.php

@@ -58,7 +58,7 @@ public function execute(InputInterface $input, OutputInterface $output)
             $this->showProperties = true;
         }
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
 
         $this->renderNode($currentNode, $table);
 

src/PHPCR/Shell/Console/Command/Phpcr/NodeReferencesCommand.php

@@ -52,7 +52,7 @@ public function execute(InputInterface $input, OutputInterface $output)
         $references['weak'] = $currentNode->getWeakReferences($name ? : null);
         $references['strong'] = $currentNode->getReferences($name ? : null);
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
         $table->setHeaders(array(
             'Type', 'Property', 'Node Path'
         ));

src/PHPCR/Shell/Console/Command/Phpcr/NodeTypeListCommand.php

@@ -30,7 +30,7 @@ public function execute(InputInterface $input, OutputInterface $output)
 
         $nodeTypes = $nodeTypeManager->getAllNodeTypes();
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
         $table->setHeaders(array('Name', 'Primary Item Name', 'Abstract?', 'Mixin?', 'Queryable?'));
 
         foreach ($nodeTypes as $nodeType) {

src/PHPCR/Shell/Console/Command/Phpcr/RepositoryDescriptorListCommand.php

@@ -25,7 +25,7 @@ public function execute(InputInterface $input, OutputInterface $output)
         $repository = $session->getRepository();
         $keys = $repository->getDescriptorKeys();
 
-        $table = clone $this->getHelper('table');
+        $table = $this->getHelper('table')->create();
         $table->setHeaders(array('Key', 'Value', 'Standard?'));
 
         foreach ($keys as $key) {