Merge pull request #67 from phpcr/always_use_absolute_path

Error on non-eistant file and expand path for profile

Author: dantleech

CHANGELOG.md

@@ -18,6 +18,11 @@ alpha-4
 - [args] 28 instances of bad InputArgument constructor fixed
 - [node] `node:list` Catch exceptions when rendering property rows (e.g. on invalid references)
 
+### Improvements
+
+- [connect] Always expand relative paths for `db-path`
+- [connect] Throw exception if file indicated by `db-path` does not exist.
+
 alpha-3
 -------
 

src/PHPCR/Shell/Subscriber/ProfileFromSessionInputSubscriber.php

@@ -38,7 +38,26 @@ public function handleProfileInit(ProfileInitEvent $e)
         );
 
         foreach ($transportOptions as $optionName => $configName) {
-            $profile->set('transport', $configName, (string) $input->getOption($optionName));
+            $value = $input->getOption($optionName);
+
+            if (null !== $value) {
+                // sanitize some input values
+                switch ($optionName) {
+                    case 'db-path':
+                        if (!file_exists($value)) {
+                            throw new \InvalidArgumentException(sprintf(
+                                'DB file "%s" does not exist.'
+                            , $value));
+                        }
+
+                        $value = realpath(dirname($value)) . DIRECTORY_SEPARATOR . basename($value);
+                        break;
+                    default:
+                        // all good
+                }
+            }
+
+            $profile->set('transport', $configName, (string) $value);
         }
 
         foreach ($phpcrOptions as $optionName => $configName) {