Skip to content

Commit ca3851a

Browse files
committed
this was never respecting the interface but relying on bugs in jackalope: skipTo is milliseconds, not seconds
1 parent e700d3d commit ca3851a

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

tests/12_Observation/ObservationManagerTest.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function testGetUnfilteredEventJournal()
2828
{
2929
sleep(1); // To avoid having the same date as the journal entries generated by the fixtures loading
3030

31-
$curTime = strtotime('now');
31+
$curTime = time() * 1000;
3232

3333
$producerSession = self::$loader->getSession();
3434
$consumerSession = self::$loader->getSession();
@@ -45,7 +45,7 @@ public function testFilteredEventJournal()
4545
{
4646
sleep(1); // To avoid having the same date as the journal entries generated by the fixtures loading or other tests
4747

48-
$curTime = strtotime('now');
48+
$curTime = time() * 1000;
4949

5050
$session = self::$loader->getSession();
5151
$om = $session->getWorkspace()->getObservationManager();
@@ -65,7 +65,7 @@ public function testFilteredEventJournalUuid()
6565
{
6666
sleep(1); // To avoid having the same date as the journal entries generated by the fixtures loading or other tests
6767

68-
$curTime = strtotime('now');
68+
$curTime = time() * 1000;
6969
$session = self::$loader->getSession();
7070
$om = $session->getWorkspace()->getObservationManager();
7171

@@ -105,7 +105,7 @@ public function testFilteredEventJournalNodeType()
105105
$session->save();
106106
sleep(1); // To avoid having the same date as the journal entries generated by the fixtures loading or other tests
107107

108-
$curTime = strtotime('now');
108+
$curTime = time() * 1000;
109109
$om = $session->getWorkspace()->getObservationManager();
110110

111111
$node->addNode('unstructured');
@@ -151,7 +151,7 @@ public function testUserData()
151151

152152
sleep(1); // To avoid having the same date as journal entries generated by previous tests
153153

154-
$curTime = time();
154+
$curTime = time() * 1000;
155155
$producerOm->setUserData($userData);
156156

157157
// Produce some events in the producer session
@@ -337,8 +337,7 @@ protected function expectEventsInAnyOrder(EventJournalInterface $journal, $event
337337
if (array_key_exists($hash, $expectedEvents)) {
338338
unset($expectedEvents[$hash]);
339339
} else {
340-
var_dump($hash);
341-
$this->Fail(sprintf("Unexpected event found, type = %s, path = %s", $event->getType(), $event->getPath()));
340+
$this->Fail(sprintf("Unexpected event found, type = %s, path = %s, hash = %s", $event->getType(), $event->getPath(), $hash));
342341
}
343342
}
344343

@@ -455,7 +454,7 @@ protected function expectEventsWithUserData(EventJournalInterface $journal, $sta
455454
* @param $journal
456455
* @return void
457456
*/
458-
protected function varDumpJournal($journal)
457+
protected function varDumpJournal(EventJournalInterface $journal)
459458
{
460459
echo "JOURNAL DUMP:\n";
461460
while ($journal->valid()) {

0 commit comments

Comments
 (0)