added binary multivalue read tests with 1/0 values

Author: bitpetr

fixtures/general/base.xml

@@ -53,6 +53,11 @@
                 <sv:value>aDEuIENoYXB0ZXIgMSBUaXRsZQoKKiBmb28KKiBiYXIKKiogZm9vMgoqKiBmb28zCiogZm9vMAoKfHwgaGVhZGVyIHx8IGJhciB8fAp8IGggfCBqIHwKCntjb2RlfQpoZWxsbyB3b3JsZAp7Y29kZX0KCiMgZm9vCg==</sv:value>
                 <sv:value>aDEuIENoYXB0ZXIgMSBUaXRsZQoKKiBmb28KKiBiYXIKKiogZm9vMgoqKiBmb28zCiogZm9vMAoKfHwgaGVhZGVyIHx8IGJhciB8fAp8IGggfCBqIHwKCntjb2RlfQpoZWxsbyB3b3JsZAp7Y29kZX0KCiMgZm9vCg==</sv:value>
             </sv:property>
+            <sv:property sv:name="single_multidata" sv:type="Binary" sv:multiple="true">
+                <sv:value></sv:value>
+            </sv:property>
+            <sv:property sv:name="empty_multidata" sv:type="Binary" sv:multiple="true">
+            </sv:property>
             <sv:property sv:name="jcr:lastModified" sv:type="Date">
                 <sv:value>2009-04-27T13:01:07.472+02:00</sv:value>
             </sv:property>

tests/Reading/BinaryReadMethodsTest.php

@@ -146,4 +146,33 @@ public function testReadBinaryPathTrailingQuestionmark()
         $this->assertInternalType('string', $value);
         $this->assertEquals($this->decodedstring, $value);
     }
+
+    /**
+     * Verifies that we still can read empty data from multivalue binary properties
+     * @group multitest
+     */
+    public function testReadEmptyBinaryMultivalue()
+    {
+        $node = $this->session->getRootNode()->getNode('tests_general_base/index.txt/jcr:content');
+        $empty = $node->getProperty('empty_multidata');
+        $this->assertEquals(\PHPCR\PropertyType::BINARY, $empty->getType());
+        $emptyValue = $empty->getBinary();
+        $this->assertTrue(is_array($emptyValue));
+        $this->assertTrue(count($emptyValue) === 0);
+    }
+
+    /**
+     * Verifies that we still can read empty data from multivalue binary properties
+     */
+    public function testReadSingleBinaryMultivalue()
+    {
+        $node = $this->session->getRootNode()->getNode('tests_general_base/index.txt/jcr:content');
+        $single = $node->getProperty('single_multidata');
+        $this->assertEquals(\PHPCR\PropertyType::BINARY, $single->getType());
+        $singleValue = $single->getBinary();
+        $this->assertTrue(is_array($singleValue));
+        $this->assertTrue(is_resource($singleValue[0]));
+        $contents = stream_get_contents($singleValue[0]);
+        $this->assertEquals('', $contents);
+    }
 }