Skip to content

Commit 2d7c8ac

Browse files
committed
Merge pull request #90 from phpcr/importer-bug
trigger a bug we had in jackalope with parsing
2 parents dd64a2d + 2e082a8 commit 2d7c8ac

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

fixtures/general/base.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,9 @@
370370
<sv:value>10</sv:value>
371371
</sv:property>
372372

373+
<!-- at the very end of the document on purpose -->
374+
<sv:property sv:name="multi-empty" sv:type="String" sv:multiple="true"></sv:property>
375+
<sv:property sv:name="multi-empty-selfclosing" sv:type="String" sv:multiple="true"/>
373376
</sv:node>
374377
</sv:node>
375378

tests/11_Import/ImportRepositoryContentTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ private function doTestImportXMLSystem($connect, $session)
6060
}
6161

6262
/**
63-
* @expectedException PHPCR\PathNotFoundException
63+
* @expectedException \PHPCR\PathNotFoundException
6464
*/
6565
public function testImportXMLSystemPathNotFoundSession()
6666
{
6767
$session = $this->sharedFixture['session'];
6868
$session->importXML('/inexistent-path', __DIR__.'/../../fixtures/general/base.xml', ImportUUIDBehaviorInterface::IMPORT_UUID_COLLISION_THROW);
6969
}
7070
/**
71-
* @expectedException PHPCR\PathNotFoundException
71+
* @expectedException \PHPCR\PathNotFoundException
7272
*/
7373
public function testImportXMLSystemPathNotFoundWorkspace()
7474
{
@@ -77,7 +77,7 @@ public function testImportXMLSystemPathNotFoundWorkspace()
7777
}
7878

7979
/**
80-
* @expectedException PHPCR\ItemExistsException
80+
* @expectedException \PHPCR\ItemExistsException
8181
*/
8282
public function testImportXMLSystemIdCollisionSession()
8383
{
@@ -87,7 +87,7 @@ public function testImportXMLSystemIdCollisionSession()
8787
}
8888

8989
/**
90-
* @expectedException PHPCR\ItemExistsException
90+
* @expectedException \PHPCR\ItemExistsException
9191
*/
9292
public function testImportXMLSystemIdCollisionWorkspace()
9393
{
@@ -98,7 +98,7 @@ public function testImportXMLSystemIdCollisionWorkspace()
9898

9999
/**
100100
* try to replace the path to which we are importing atm
101-
* @expectedException PHPCR\NodeType\ConstraintViolationException
101+
* @expectedException \PHPCR\NodeType\ConstraintViolationException
102102
*/
103103
public function testImportXMLUuidRemoveParentSession()
104104
{
@@ -109,7 +109,7 @@ public function testImportXMLUuidRemoveParentSession()
109109

110110
/**
111111
* try to replace the path to which we are importing atm
112-
* @expectedException PHPCR\NodeType\ConstraintViolationException
112+
* @expectedException \PHPCR\NodeType\ConstraintViolationException
113113
*/
114114
public function testImportXMLUuidRemoveParentWorkspace()
115115
{
@@ -316,7 +316,7 @@ public function testImportXMLUuidReplaceRoot()
316316
/**
317317
* Provoke an io error
318318
*
319-
* @expectedException RuntimeException
319+
* @expectedException \RuntimeException
320320
*/
321321
public function testImportXMLNoFile()
322322
{

0 commit comments

Comments
 (0)