Improve sql query in total contribs method and format template

Author: danieltj27

config/config.php

@@ -380,4 +380,4 @@ public function get_configurables()
 //			'repack_diff_extensions'
 		);
 	}
-}
+}

event/main_listener.php

@@ -415,7 +415,7 @@ public function quote_text_upon_pm($event)
 	}
 
 	/**
-	 * @todo
+	 * Display contribution count and link to Titania profile in memberlist.php.
 	 * @param $event
 	 */
 	public function add_memberlist_template_vars($event)
@@ -428,19 +428,16 @@ public function add_memberlist_template_vars($event)
 
 		$this->language->add_lang(['memberlist'], 'phpbb/titania');
 
-		$sql_ary = array(
-			'SELECT' => 'COUNT(*)',
-			'FROM' => [
-				TITANIA_CONTRIBS_TABLE => 'c',
-			],
-			'WHERE' => 'c.contrib_user_id = ' . $event['member']['user_id'] . ' AND c.contrib_status = 2',
-		);
+		$sql = 'SELECT COUNT(contrib_id) as contribs
+		    FROM ' . TITANIA_CONTRIBS_TABLE . '
+		    WHERE contrib_user_id = ' . (int) $event['member']['user_id'] . '
+		      AND contrib_status = 2';
 
-		$sql = $this->db->sql_build_query('SELECT', $sql_ary);
 		$result = $this->db->sql_query($sql);
-		$contribs = $this->db->sql_fetchrow($result);
 
-		$u_total_contribs = intval($contribs['COUNT(*)']);
+		$u_total_contribs = (int) $this->db->sql_fetchfield('contribs');
+
+		$db->sql_freeresult($result);
 
 		$u_user_contribs = $this->controller_helper->route('phpbb.titania.author', array(
 			'author'	=> urlencode($event['member']['username_clean']),

styles/all/template/event/memberlist_view_user_statistics_after.html

@@ -1 +1,9 @@
-<dt>{{ lang('USER_TOTAL_CONTRIBUTIONS') }}{{ lang('COLON') }}</dt> <dd>{{ U_USER_CONTRIB_TOTAL }} | <strong><a href="{{ U_USER_CONTRIB_LINK }}">{{ lang('SEARCH_USER_CONTRIBUTIONS') }}</a></strong></dd>
+<dt>{{ lang('USER_TOTAL_CONTRIBUTIONS') }}{{ lang('COLON') }}</dt>
+<dd>
+	{{ U_USER_CONTRIB_TOTAL }} |
+	<strong>
+		<a href="{{ U_USER_CONTRIB_LINK }}">
+			{{ lang('SEARCH_USER_CONTRIBUTIONS') }}
+		</a>
+	</strong>
+</dd>