PHP compat: allowed classes are required as a 2nd argument

Skouat · Skouat · commit 9105c12b57e4 · 2022-08-30T18:13:50.000+02:00
diff --git a/controller/search.php b/controller/search.php
@@ -525,7 +525,7 @@ protected function assign_doc_vars($documents)
 	 */
 	protected function get_document_url($type, $params)
 	{
-		$params = unserialize($params);
+		$params = unserialize($params, ['allowed_classes' => false]);
 
 		switch ($type)
 		{
@@ -660,7 +660,7 @@ protected function get_posts(array $ids, array $documents, bool $is_sphinx)
 		while ($row = $this->db->sql_fetchrow($result))
 		{
 			$id = $row['post_type'] . '_' . ($is_sphinx ? $row['id'] + 20000000 : $row['id']);
-			$row['url'] = serialize(array_merge(unserialize($row['url']), array(
+			$row['url'] = serialize(array_merge(unserialize($row['url'], ['allowed_classes' => false]), array(
 				'topic_id' => $row['topic_id'],
 				'p'        => $row['id'],
 				'#'        => 'p' . $row['id'],

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,7 @@ protected function assign_doc_vars($documents)`
`525`	`525`	`*/`
`526`	`526`	`protected function get_document_url($type, $params)`
`527`	`527`	`{`
`528`		`- $params = unserialize($params);`
	`528`	`+ $params = unserialize($params, ['allowed_classes' => false]);`
`529`	`529`
`530`	`530`	`switch ($type)`
`531`	`531`	`{`
`@@ -660,7 +660,7 @@ protected function get_posts(array $ids, array $documents, bool $is_sphinx)`
`660`	`660`	`while ($row = $this->db->sql_fetchrow($result))`
`661`	`661`	`{`
`662`	`662`	`$id = $row['post_type'] . '_' . ($is_sphinx ? $row['id'] + 20000000 : $row['id']);`
`663`		`- $row['url'] = serialize(array_merge(unserialize($row['url']), array(`
	`663`	`+ $row['url'] = serialize(array_merge(unserialize($row['url'], ['allowed_classes' => false]), array(`
`664`	`664`	`'topic_id' => $row['topic_id'],`
`665`	`665`	`'p' => $row['id'],`
`666`	`666`	`'#' => 'p' . $row['id'],`