Merge pull request #350 from iMattPro/fixes-php8

Fixing stuff that won’t work with PHP 8

Author: iMattPro

attachment/attachment.php

@@ -352,12 +352,6 @@ public function create_thumbnail($max_width = false, $min_filesize = false)
 					imagecopyresampled($new_image, $image, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
 				}
 
-				// If we are in safe mode create the destination file prior to using the gd functions to circumvent a PHP bug
-				if (@ini_get('safe_mode') || @strtolower(ini_get('safe_mode')) == 'on')
-				{
-					@touch($destination);
-				}
-
 				switch ($type['format'])
 				{
 					case IMG_GIF:

composer.json

@@ -61,7 +61,7 @@
         }
     ],
     "require": {
-        "php": ">=5.3.3",
+        "php": "^7.1.3",
         "phpbb/epv": "dev-master@dev",
         "phpbb/translation-validator": "~1.5",
         "composer/installers": "~1.0",
@@ -71,7 +71,7 @@
     "extra": {
         "display-name": "phpBB Customisation Database (Titania)",
         "soft-require": {
-            "phpbb/phpbb": "3.2.*@dev"
+            "phpbb/phpbb": "3.3.*@dev"
         }
     }
 }

includes/objects/author.php

@@ -352,7 +352,7 @@ public function assign_details($return = false, $row= false, $revert = true)
 				}
 			}
 		}
-		$vars['AUTHOR_CONTRIB_LIST'] = implode($type_list, ', ');
+		$vars['AUTHOR_CONTRIB_LIST'] = implode(', ', $type_list);
 
 		/* @todo: automatically display the common author data too...
 		if (isset($this->sql_data))

includes/overlords/attention.php

@@ -230,7 +230,7 @@ public static function display_attention_list($options = array(), $sort = false)
 			);
 
 			// Do we have to?
-			if ($row['attention_close_user'])
+			if (!empty($row['attention_close_user']))
 			{
 				$output = array_merge(
 					$output,

includes/overlords/users.php

@@ -165,7 +165,7 @@ public static function get_user($user_id, $field = false, $query = false)
 		}
 
 		// Special things...
-		if ($field[0] == '_')
+		if (strpos($field, '_') === 0)
 		{
 			switch ($field)
 			{