Skip to content

Commit d40ae99

Browse files
committed
Update TODO after hook support
1 parent e4b852a commit d40ae99

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

TOLERANT_TODO.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ Double-check tolerant against the language changes that shipped with 8.3:
2323

2424
### PHP 8.4
2525

26-
- **Property access hooks** (`public int $count { get => ...; set { ... } }`):
26+
- **Property access hooks** (`public int $count { get => ...; set { ... } }`): **(implemented)**
2727
- Tokenizer must recognise `get`/`set` (and hook modifiers) in this context.
2828
- Introduce AST nodes for hook lists/bodies that align with php-ast’s `AST_PROP_ELEM` `hooks` child.
2929
- Update diagnostics to catch invalid hook combinations.
30+
- Conversion now produces `AST_PROPERTY_HOOK`/`AST_PROPERTY_HOOK_SHORT_BODY` nodes; add regression coverage to guard against regressions.
3031
- **Asymmetric visibility v2** (`public(set) private(get) $prop;`): extend the modifier grammar, update `TokenKind`, and cover tolerant AST flag handling.
3132
- **`new Foo()->bar()` without wrapping parentheses**: confirm parser handles the reduced precedence and add regression tests.
3233
- **Property hook improvements** (hook attributes, multiple hooks per property, etc.): ensure attribute placement and hook ordering are represented correctly.

0 commit comments

Comments
 (0)