Also handle new #[MyAttr] class {...}

I forgot that anonymous classes were parsed into an
ObjectCreationExpression instead.

Also support attributes there, cause a diagnostic to be emitted if the
attribute group(s) aren't followed by the `class` keyword.

For microsoft#320

Author: TysonAndre

src/Node/Expression/ObjectCreationExpression.php

@@ -6,6 +6,7 @@
 
 namespace Microsoft\PhpParser\Node\Expression;
 
+use Microsoft\PhpParser\Node\AttributeGroup;
 use Microsoft\PhpParser\Node\ClassBaseClause;
 use Microsoft\PhpParser\Node\ClassInterfaceClause;
 use Microsoft\PhpParser\Node\ClassMembersNode;
@@ -19,6 +20,9 @@ class ObjectCreationExpression extends Expression {
     /** @var Token */
     public $newKeword;
 
+    /** @var AttributeGroup[]|null optional attributes of an anonymous class. */
+    public $attributes;
+
     /** @var QualifiedName|Variable|Token */
     public $classTypeDesignator;
 
@@ -41,7 +45,8 @@ class ObjectCreationExpression extends Expression {
     public $classMembers;
 
     const CHILD_NAMES = [
-        'newKeword', // TODO
+        'newKeword',
+        'attributes',
         'classTypeDesignator',
         'openParen',
         'argumentExpressionList',

src/Parser.php

@@ -3088,6 +3088,12 @@ private function parseObjectCreationExpression($parentNode) {
         // TODO - add tests for this scenario
         $oldIsParsingObjectCreationExpression = $this->isParsingObjectCreationExpression;
         $this->isParsingObjectCreationExpression = true;
+
+        if ($this->getCurrentToken()->kind === TokenKind::AttributeToken) {
+            // Attributes such as `new #[MyAttr] class` can only be used with anonymous class declarations.
+            // But handle this like $objectCreationExpression->classMembers and leave it up to the applications to detect the invalid combination.
+            $objectCreationExpression->attributes = $this->parseAttributeGroups($objectCreationExpression);
+        }
         $objectCreationExpression->classTypeDesignator =
             $this->eatOptional1(TokenKind::ClassKeyword) ??
             $this->parseExpression($objectCreationExpression);

tests/cases/parser/callExpression14.php.tree

@@ -27,6 +27,7 @@
                                                 "kind": "NewKeyword",
                                                 "textLength": 3
                                             },
+                                            "attributes": null,
                                             "classTypeDesignator": {
                                                 "QualifiedName": {
                                                     "globalSpecifier": null,

tests/cases/parser/listExpression9.php.tree

@@ -128,6 +128,7 @@
                                         "kind": "NewKeyword",
                                         "textLength": 3
                                     },
+                                    "attributes": null,
                                     "classTypeDesignator": {
                                         "QualifiedName": {
                                             "globalSpecifier": null,

tests/cases/parser/objectCreationExpression1.php.tree

@@ -19,6 +19,7 @@
                                 "kind": "NewKeyword",
                                 "textLength": 3
                             },
+                            "attributes": null,
                             "classTypeDesignator": {
                                 "QualifiedName": {
                                     "globalSpecifier": null,

tests/cases/parser/objectCreationExpression10.php.tree

@@ -35,6 +35,7 @@
                                         "kind": "NewKeyword",
                                         "textLength": 3
                                     },
+                                    "attributes": null,
                                     "classTypeDesignator": {
                                         "kind": "ClassKeyword",
                                         "textLength": 5

tests/cases/parser/objectCreationExpression11.php.tree

@@ -35,6 +35,7 @@
                                         "kind": "NewKeyword",
                                         "textLength": 3
                                     },
+                                    "attributes": null,
                                     "classTypeDesignator": {
                                         "kind": "ClassKeyword",
                                         "textLength": 5

tests/cases/parser/objectCreationExpression12.php.tree

@@ -35,6 +35,7 @@
                                         "kind": "NewKeyword",
                                         "textLength": 3
                                     },
+                                    "attributes": null,
                                     "classTypeDesignator": {
                                         "kind": "ClassKeyword",
                                         "textLength": 5

tests/cases/parser/objectCreationExpression13.php.tree

@@ -35,6 +35,7 @@
                                         "kind": "NewKeyword",
                                         "textLength": 3
                                     },
+                                    "attributes": null,
                                     "classTypeDesignator": {
                                         "QualifiedName": {
                                             "globalSpecifier": null,

tests/cases/parser/objectCreationExpression14.php.tree

@@ -35,6 +35,7 @@
                                         "kind": "NewKeyword",
                                         "textLength": 3
                                     },
+                                    "attributes": null,
                                     "classTypeDesignator": {
                                         "QualifiedName": {
                                             "globalSpecifier": null,