Skip to content

Commit 29c3551

Browse files
committed
Plan feature fixtures for AST diffing
1 parent 0aa4d8d commit 29c3551

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

TOLERANT_TODO.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,16 @@ Monitor RFCs merged into php-src and mirror the token/grammar changes, for examp
6767
- **Leverage Phan fixtures**: pull feature-specific testcases (e.g. property hooks, asymmetric visibility) from `phan/tests/files/src` into tolerant’s parser tests to validate new constructs.
6868
- **Run tolerant PHPUnit suites**: keep `vendor/bin/phpunit --testsuite invariants,api` (with `zend.assertions=1`) as a fast regression check while iterating.
6969

70+
Recommended sample inputs for AST diffs (update as new fixtures are added):
71+
72+
| Feature | Sample file(s) | Min PHP | Native AST dump | Tolerant dump |
73+
| --- | --- | --- | --- | --- |
74+
| Dynamic class const fetch | `phan/tests/files/src/0847_dynamic_class_const.php` (create) | 8.3 | `php tools/dump_ast.php …` | `php tools/PrintTolerantAst.php …` |
75+
| Property hooks | `phan/tests/files/src/1166_property_hooks.php` | 8.4 | `php tools/dump_ast.php …` | `php tools/PrintTolerantAst.php …` |
76+
| Asymmetric visibility props | (add fixture) | 8.4 |||
77+
| Pipe operator | (add fixture once implemented) | 8.5 |||
78+
| `clone with` expressions | (add fixture) | 8.5 |||
79+
7080
## Next Steps
7181

7282
1. Audit existing fixtures vs php-src 8.3/8.4 syntax to catalogue precise failures.

0 commit comments

Comments
 (0)