Ensure class names are unqiue

Author: dantleech

lib/Domain/ClassNameCandidates.php

@@ -20,7 +20,7 @@ public static function fromClassNames(array $classNames)
 
     public function getIterator()
     {
-        return new \ArrayIterator($this->classNames);
+        return new \ArrayIterator(array_values($this->classNames));
     }
 
     public function noneFound(): bool
@@ -41,6 +41,6 @@ public function best(): ClassName
 
     private function add(ClassName $className)
     {
-        $this->classNames[] = $className;
+        $this->classNames[$className->__toString()] = $className;
     }
 }

tests/Unit/Domain/ClassNameCandidatesTest.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Phpactor\ClassFileConverter\Tests\Unit\Domain;
+
+use PHPUnit\Framework\TestCase;
+use Phpactor\ClassFileConverter\Domain\ClassName;
+use Phpactor\ClassFileConverter\Domain\ClassNameCandidates;
+
+class ClassNameCandidatesTest extends TestCase
+{
+    public function testEnsuresClassNamesAreUnique()
+    {
+        $candidates = ClassNameCandidates::fromClassNames([
+            ClassName::fromString('Foobar'),
+            ClassName::fromString('Foobar'),
+            ClassName::fromString('Barfoo'),
+        ]);
+
+        self::assertCount(2, $candidates);
+    }
+}