Scrut. optimization

Author: jcheron

Ajax/common/Widget.php

@@ -8,6 +8,7 @@
 use Ajax\semantic\html\collections\menus\HtmlMenu;
 use Ajax\semantic\widgets\base\FieldAsTrait;
 use Ajax\semantic\html\elements\HtmlButtonGroups;
+use Ajax\semantic\widgets\base\InstanceViewer;
 
 abstract class Widget extends HtmlDoubleElement {
 	use FieldAsTrait;

Ajax/common/html/HtmlCollection.php

@@ -49,7 +49,7 @@ protected function getItemToAdd($item){
 
 	/**
 	 * adds and returns an item
-	 * @param HtmlDoubleElement|string $item
+	 * @param HtmlDoubleElement|string|array $item
 	 * @return \Ajax\common\html\HtmlDoubleElement
 	 */
 	public function addItem($item){

Ajax/semantic/html/base/traits/MenuItemTrait.php

@@ -6,6 +6,12 @@
 use Ajax\semantic\html\elements\HtmlInput;
 use Ajax\semantic\html\base\constants\Direction;
 
+/**
+ * @author jc
+ * @property string $identifier
+ * @property mixed $content
+ * @property string $tagName
+ */
 trait MenuItemTrait {
 
 	public function setContent($content){

Ajax/semantic/html/collections/form/traits/CheckboxTrait.php

@@ -5,6 +5,10 @@
 use Ajax\semantic\html\base\constants\CheckboxType;
 use Ajax\semantic\html\modules\checkbox\AbstractCheckbox;
 
+/**
+ * @author jc
+ * @property mixed $content
+ */
 trait CheckboxTrait {
 
 	public abstract function addToPropertyCtrl($name, $value, $typeCtrl);

Ajax/semantic/html/collections/form/traits/FieldTrait.php

@@ -7,6 +7,11 @@
 use Ajax\semantic\html\base\constants\Direction;
 use Ajax\semantic\html\base\constants\State;
 
+/**
+ * @author jc
+ * @property boolean $_hasIcon
+ * @property string $identifier
+ */
 trait FieldTrait {
 
 	abstract public function addToProperty($name, $value, $separator=" ");

Ajax/semantic/html/collections/form/traits/FieldsTrait.php

@@ -10,6 +10,10 @@
 use Ajax\semantic\html\collections\form\HtmlFormRadio;
 use Ajax\semantic\html\collections\form\HtmlFormField;
 
+/**
+ * @author jc
+ * @property string $identifier
+ */
 trait FieldsTrait {
 	public abstract function addFields($fields=NULL,$label=NULL);
 	public abstract function addItem($item);

Ajax/semantic/html/content/HtmlMenuItem.php

@@ -24,7 +24,7 @@ protected function initContent($content){
 				$desc=@$content["description"];
 			}
 			if(isset($icon)===true){
-				$this->setIcon($icon);
+				$this->addIcon($icon);
 			}
 			if(isset($title)===true){
 				$this->setTitle($title,$desc);

Ajax/semantic/html/content/InternalPopup.php

@@ -5,13 +5,15 @@
 use Ajax\JsUtils;
 use Ajax\service\JString;
 use Ajax\semantic\html\base\HtmlSemDoubleElement;
+
 class InternalPopup {
 	protected $title;
 	protected $content;
 	protected $html;
 	protected $variation;
 	protected $params;
 	protected $semElement;
+
 	public function __construct($semElement,$title="",$content="",$variation=NULL,$params=array()){
 		$this->semElement=$semElement;
 		$this->title=$title;
@@ -46,9 +48,11 @@ public function compile(JsUtils $js=NULL){
 				\array_walk($html, function(&$item) use($js){
 					if($item instanceof HtmlSemDoubleElement){
 						$comp=$item->compile($js);
-						$bs=$item->run($js);
-						if(isset($bs))
-							$this->params['onShow']=$bs->getScript();
+						if(isset($js)){
+							$bs=$item->run($js);
+							if(isset($bs))
+								$this->params['onShow']=$bs->getScript();
+						}
 						$item=$comp;
 					}
 				});

Ajax/semantic/html/content/table/HtmlTableContent.php

@@ -37,13 +37,6 @@ public function setRowCount($rowCount, $colCount) {
 		for($i=$count; $i < $rowCount; $i++) {
 			$this->addItem($colCount);
 		}
-		/*
-		 * for($i=0; $i < $rowCount; $i++) {
-		 * $item=$this->content[$i];
-		 * $item->setTdTagName($this->_tdTagNames[$this->tagName]);
-		 * $this->content[$i]->setColCount($colCount);
-		 * }
-		 */
 		return $this;
 	}
 

Ajax/semantic/html/elements/HtmlButton.php

@@ -99,7 +99,7 @@ public function asSubmit() {
 	/**
 	 * Add and return a button label
 	 * @param string $caption
-	 * @param string $before
+	 * @param boolean $before
 	 * @param string $icon
 	 * @return \Ajax\semantic\html\elements\HtmlLabel
 	 */