Fix Scrut bugs

Author: jcheron

Ajax/bootstrap/html/HtmlButtontoolbar.php

@@ -70,9 +70,9 @@ public function getLastGroup() {
 		return $bg;
 	}
 
-	/*
-	 * (non-PHPdoc)
-	 * @see \Ajax\bootstrap\html\HtmlButtongroups::getElement()
+	
+	/**
+	 * @return HtmlButtongroups|HtmlButton
 	 */
 	public function getElement($index) {
 		$element=null;

Ajax/bootstrap/html/HtmlModal.php

@@ -201,6 +201,7 @@ public function setDraggable($value) {
 	 * @return HtmlModal
 	 */
 	public function setBackdrop($value) {
-		return $this->backdrop=$value;
+		$this->backdrop=$value;
+		return $this;
 	}
 }

Ajax/common/html/traits/BaseHtmlEventsTrait.php

@@ -2,7 +2,6 @@
 namespace Ajax\common\html\traits;
 use Ajax\JsUtils;
 use Ajax\service\AjaxCall;
-use Ajax\common\components\SimpleExtComponent;
 use Ajax\service\Javascript;
 use Ajax\common\html\BaseHtml;
 

Ajax/common/traits/JsUtilsInternalTrait.php

@@ -15,7 +15,7 @@ protected function _addToCompile($jsScript) {
 	 * @param BaseGui $library
 	 * @param mixed $view
 	 */
-	protected function _compileLibrary(BaseGui $library=NULL, &$view=NULL){
+	protected function _compileLibrary(BaseGui $library, &$view=NULL){
 		if(isset($view))
 			$library->compileHtml($this, $view);
 		if ($library->isAutoCompile()) {

Ajax/semantic/html/base/HtmlSemNavElement.php

@@ -36,7 +36,7 @@ public function __construct($identifier,$tagName,$baseClass){
 	/**
 	 * Associate an ajax get to the elements, displayed in $targetSelector
 	 * @param string $targetSelector the target of the get
-	 * @return HtmlNavElement
+	 * @return HtmlSemNavElement
 	 */
 	public function autoGetOnClick($targetSelector){
 		return $this->getOnClick($this->root, $targetSelector,array("attr"=>$this->attr));

Ajax/semantic/html/collections/HtmlGrid.php

@@ -205,11 +205,11 @@ public function colCount() {
 	public function getCell($row, $col) {
 		if ($row < 2 && $this->hasOnlyCols($this->count()))
 			return $this->getItem($col);
-		$row=$this->getItem($row);
-		if (isset($row)) {
-			$col=$row->getItem($col);
+		$rowO=$this->getItem($row);
+		if (isset($rowO)) {
+			$colO=$rowO->getItem($col);
 		}
-		return $col;
+		return $colO;
 	}
 
 	/**
@@ -319,8 +319,17 @@ public function setStretched() {
 		return $this->addToProperty("class", "stretched");
 	}
 
+	/**
+	 * Adds a divider after the specified col
+	 * @param integer $afterColIndex
+	 * @param boolean $vertical
+	 * @param mixed $content
+	 * @return \Ajax\semantic\html\collections\HtmlGrid
+	 */
 	public function addDivider($afterColIndex, $vertical=true, $content=NULL) {
 		$col=$this->getCell(0, $afterColIndex);
-		return $col->addDivider($vertical, $content);
+		if($col instanceof HtmlGridCol)
+			$col->addDivider($vertical, $content);
+		return $this;
 	}
 }

Ajax/semantic/html/collections/form/traits/FieldTrait.php

@@ -68,7 +68,7 @@ public function labeledToCorner($icon, $direction=Direction::LEFT) {
 	}
 
 	/**
-	 * @param mixed $action
+	 * @param string $action
 	 * @param string $direction
 	 * @param string $icon
 	 * @param boolean $labeled

Ajax/semantic/html/content/table/HtmlTableContent.php

@@ -6,6 +6,7 @@
 use Ajax\service\JArray;
 use Ajax\common\html\HtmlCollection;
 use Ajax\common\html\HtmlDoubleElement;
+use Ajax\semantic\html\base\traits\BaseTrait;
 
 /**
  * a table content (thead, tbody or tfoot)
@@ -187,7 +188,9 @@ public function setColValues($colIndex, $values=array()) {
 	public function addColVariations($colIndex, $variations=array()) {
 		$count=$this->count();
 		for($i=0; $i < $count; $i++) {
-			$this->getCell($i, $colIndex)->addVariations($variations);
+			$cell=$this->getCell($i, $colIndex);
+			if($cell instanceof BaseTrait)
+				$cell->addVariations($variations);
 		}
 		return $this;
 	}

Ajax/semantic/html/content/view/HtmlViewGroups.php

@@ -47,6 +47,12 @@ public function setWide($wide) {
 
 	abstract public function newItem($identifier);
 
+	/**
+	 * @return HtmlViewGroups
+	 */
+	public function getItem($index){
+		return parent::getItem($index);
+	}
 
 	public function getItemContent($itemIndex, $contentIndex) {
 		$item=$this->getItem($itemIndex);

Ajax/semantic/html/elements/HtmlButton.php

@@ -254,9 +254,9 @@ public function asLink($href=NULL,$target=NULL) {
 	 */
 	public static function dropdown($identifier,$value,$items=[],$asCombo=false,$icon=null){
 		$result=new HtmlButtonGroups($identifier,[$value]);
-		$result->addDropdown($items,$asCombo);
+		$dd=$result->addDropdown($items,$asCombo);
 		if(isset($icon))
-			$result->setIcon($icon);
+			$dd->setIcon($icon);
 		return $result;
 	}
 }