[TASK] Handle "valid Document entries" as absolute document paths

Author: linawolf

packages/guides/src/UrlGenerator.php

@@ -94,20 +94,20 @@ public function generateOutputUrlFromDocumentPath(
         string $outputFormat,
         string|null $anchor = null,
     ): string {
+        if ($validDocumentEntry) {
+            $linkedDocument = '/' . $linkedDocument;
+        }
+
+        $fileUrl = $this->createFileUrl($linkedDocument, $outputFormat, $anchor);
         if (UriInfo::isAbsolutePath(Uri::createFromString($linkedDocument))) {
-            return $destinationPath . $this->createFileUrl($linkedDocument, $outputFormat, $anchor);
+            return $destinationPath . $fileUrl;
         }
 
         $baseUrl = ltrim($this->absoluteUrl($destinationPath, $currentDirectory), '/');
 
-        if ($validDocumentEntry) {
-            return $destinationPath . '/'
-                . $this->createFileUrl($linkedDocument, $outputFormat, $anchor);
-        }
-
         return $this->canonicalUrl(
             $baseUrl,
-            $this->createFileUrl($linkedDocument, $outputFormat, $anchor),
+            $fileUrl,
         );
     }
 }

packages/guides/tests/unit/UrlGeneratorTest.php

@@ -191,6 +191,20 @@ public static function documentPathProvider(): array
                 'linkedDocument' => '../references/installing',
                 'result' => 'guide/references/installing.txt',
             ],
+            'relative document path up in subdirectory' => [
+                'currentDirectory' => 'getting-started/something',
+                'destinationPath' => 'guide',
+                'validDocumentEntry' => false,
+                'linkedDocument' => '../references/installing',
+                'result' => 'guide/getting-started/references/installing.txt',
+            ],
+            'relative document path two up in directory' => [
+                'currentDirectory' => 'getting-started/something',
+                'destinationPath' => 'guide',
+                'validDocumentEntry' => false,
+                'linkedDocument' => '../../references/installing',
+                'result' => 'guide/references/installing.txt',
+            ],
         ];
     }
 }