Improve buffer calls

Author: jaapio

packages/guides-restructured-text/src/RestructuredText/Parser/Buffer.php

@@ -103,21 +103,29 @@ public function clear(): void
 
     public function trimLines(): void
     {
-        array_walk($this->lines, static function (&$value): void {
-            $value = trim($value);
-        });
+        foreach ($this->lines as $i => $line) {
+            $this->lines[$i] = trim($line);
+        }
     }
 
     private function unIndent(): void
     {
+        if ($this->unindentStrategy === UnindentStrategy::NONE) {
+            return;
+        }
+
         $indentation = $this->detectIndentation();
-        array_walk($this->lines, static function (&$value) use ($indentation): void {
-            if (strlen($value) < $indentation) {
-                return;
+        if ($indentation === 0) {
+            return;
+        }
+
+        foreach ($this->lines as $i => $line) {
+            if (strlen($line) < $indentation) {
+                continue;
             }
 
-            $value = substr($value, $indentation);
-        });
+            $this->lines[$i] = substr($line, $indentation);
+        }
     }
 
     private function detectIndentation(): int

packages/guides-restructured-text/tests/benchmarks/BufferBench.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace phpDocumentor\Guides\RestructuredText;
+
+use PhpBench\Attributes\Iterations;
+use PhpBench\Attributes\Revs;
+use phpDocumentor\Guides\RestructuredText\Parser\Buffer;
+
+final class BufferBench
+{
+    private Buffer $buffer;
+
+    public function __construct()
+    {
+        $this->buffer = new Buffer();
+        $this->buffer->push('   This is a line with leading spaces.   ');
+        $this->buffer->push(' This is another line.');
+        $this->buffer->push(' Yet another line with spaces.   ');
+        $this->buffer->push(' Final line.');
+    }
+
+
+    #[Revs([1000, 10_000])]
+    #[Iterations(5)]
+    public function benchGetLines(): void
+    {
+        $this->buffer->getLines();
+    }
+}