Add support for async promoted properties

Author: jaapio

composer.json

@@ -5,6 +5,9 @@
     "homepage": "http://www.phpdoc.org",
     "license": "MIT",
     "autoload": {
+        "files": [
+            "src/php-parser/Modifiers.php"
+        ],
         "psr-4": {
             "phpDocumentor\\": "src/phpDocumentor"
         }

src/php-parser/Modifiers.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpParser;
+
+use Composer\InstalledVersions;
+
+use function strpos;
+
+if (strpos(InstalledVersions::getVersion('nikic/php-parser'), '4') === 0) {
+    /**
+     * Modifiers used (as a bit mask) by various flags subnodes, for example on classes, functions,
+     * properties and constants.
+     */
+    final class Modifiers
+    {
+        public const PUBLIC = 1;
+        public const PROTECTED = 2;
+        public const PRIVATE = 4;
+        public const STATIC = 8;
+        public const ABSTRACT = 16;
+        public const FINAL = 32;
+        public const READONLY = 64;
+        public const PUBLIC_SET = 128;
+        public const PROTECTED_SET = 256;
+        public const PRIVATE_SET = 512;
+
+        public const VISIBILITY_SET_MASK = self::PUBLIC_SET | self::PROTECTED_SET | self::PRIVATE_SET;
+    }
+}

src/phpDocumentor/Reflection/Php/Factory/ConstructorPromotion.php

@@ -8,15 +8,16 @@
 use phpDocumentor\Reflection\DocBlockFactoryInterface;
 use phpDocumentor\Reflection\Fqsen;
 use phpDocumentor\Reflection\Location;
+use phpDocumentor\Reflection\Php\AsyncVisibility;
 use phpDocumentor\Reflection\Php\Class_ as ClassElement;
 use phpDocumentor\Reflection\Php\Factory\Reducer\Reducer;
 use phpDocumentor\Reflection\Php\ProjectFactoryStrategy;
 use phpDocumentor\Reflection\Php\Property;
 use phpDocumentor\Reflection\Php\StrategyContainer;
 use phpDocumentor\Reflection\Php\Visibility;
+use PhpParser\Modifiers;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Param;
-use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\PrettyPrinter\Standard as PrettyPrinter;
 use Webmozart\Assert\Assert;
@@ -91,11 +92,36 @@ private function promoteParameterToProperty(ContextStack $context, StrategyConta
 
     private function buildPropertyVisibilty(int $flags): Visibility
     {
-        if ((bool) ($flags & Class_::MODIFIER_PRIVATE) === true) {
+        if ((bool) ($flags & Modifiers::VISIBILITY_SET_MASK) !== false) {
+            return new AsyncVisibility(
+                $this->buildReadVisibility($flags),
+                $this->buildWriteVisibility($flags),
+            );
+        }
+
+        return $this->buildReadVisibility($flags);
+    }
+
+    private function buildReadVisibility(int $flags): Visibility
+    {
+        if ((bool) ($flags & Modifiers::PRIVATE) === true) {
+            return new Visibility(Visibility::PRIVATE_);
+        }
+
+        if ((bool) ($flags & Modifiers::PROTECTED) === true) {
+            return new Visibility(Visibility::PROTECTED_);
+        }
+
+        return new Visibility(Visibility::PUBLIC_);
+    }
+
+    private function buildWriteVisibility(int $flags): Visibility
+    {
+        if ((bool) ($flags & Modifiers::PRIVATE_SET) === true) {
             return new Visibility(Visibility::PRIVATE_);
         }
 
-        if ((bool) ($flags & Class_::MODIFIER_PROTECTED) === true) {
+        if ((bool) ($flags & Modifiers::PROTECTED_SET) === true) {
             return new Visibility(Visibility::PROTECTED_);
         }
 
@@ -104,6 +130,6 @@ private function buildPropertyVisibilty(int $flags): Visibility
 
     private function readOnly(int $flags): bool
     {
-        return (bool) ($flags & Class_::MODIFIER_READONLY) === true;
+        return (bool) ($flags & Modifiers::READONLY) === true;
     }
 }

src/phpDocumentor/Reflection/Types/NamespaceNodeToContext.php

@@ -58,7 +58,7 @@ private function classAlikeUses(Namespace_ $namespace): array
             static fn (Node $node): bool => (
                     $node instanceof Use_
                     || $node instanceof GroupUse
-                ) && in_array($node->type, [Use_::TYPE_UNKNOWN, Use_::TYPE_NORMAL], true)
+                ) && in_array($node->type, [Use_::TYPE_UNKNOWN, Use_::TYPE_NORMAL], true),
         );
     }
 }

tests/unit/phpDocumentor/Reflection/Middleware/ChainFactoryTest.php

@@ -53,7 +53,7 @@ public function testItThrowsAnExceptionIfAnythingOtherThanAMiddlewareIsPassed():
 
         ChainFactory::createExecutionChain(
             [$middleware],
-            static fn (): stdClass => new stdClass()
+            static fn (): stdClass => new stdClass(),
         );
     }