Null terminate the sodium_crypto_kx_keypair() result

nikic · nikic · commit f6d7af21a399 · 2020-08-14T15:51:31.000+02:00
diff --git a/ext/sodium/libsodium.c b/ext/sodium/libsodium.c
@@ -2885,6 +2885,7 @@ PHP_FUNCTION(sodium_crypto_kx_keypair)
 		zend_throw_exception(sodium_exception_ce, "internal error", 0);
 		return;
 	}
+	ZSTR_VAL(keypair)[crypto_kx_SECRETKEYBYTES + crypto_kx_PUBLICKEYBYTES] = 0;
 	RETURN_STR(keypair);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2885,6 +2885,7 @@ PHP_FUNCTION(sodium_crypto_kx_keypair)`
`2885`	`2885`	`zend_throw_exception(sodium_exception_ce, "internal error", 0);`
`2886`	`2886`	`return;`
`2887`	`2887`	`}`
	`2888`	`+ ZSTR_VAL(keypair)[crypto_kx_SECRETKEYBYTES + crypto_kx_PUBLICKEYBYTES] = 0;`
`2888`	`2889`	`RETURN_STR(keypair);`
`2889`	`2890`	`}`
`2890`	`2891`