fix memory leak in arena-alloc'd classes

This one was a doozy... apparently, methods cached by opcache are cleaned up differently and was resulting in a memory leak

Signed-off-by: Robert Landers <landers.robert@gmail.com>

Author: withinboredom

Zend/zend_compile.c

@@ -8578,7 +8578,9 @@ static zend_op_array *zend_compile_func_decl_ex(
 		op_array->fn_flags |= ZEND_ACC_PRELOADED;
 	}
 
-	if (CG(file_context).current_namespace) {
+	/* Only set namespace_name for standalone functions, not for methods.
+	 * Methods get their namespace from the class name at runtime via zend_get_caller_namespace(). */
+	if (CG(file_context).current_namespace && !CG(active_class_entry)) {
 		op_array->namespace_name = zend_string_copy(CG(file_context).current_namespace);
 	}
 

Zend/zend_language_scanner.l

@@ -609,10 +609,6 @@ static zend_op_array *zend_compile(int type)
 		init_op_array(op_array, type, INITIAL_OP_ARRAY_SIZE);
 		CG(active_op_array) = op_array;
 
-		if (CG(file_context).current_namespace) {
-			op_array->namespace_name = zend_string_copy(CG(file_context).current_namespace);
-		}
-
 		/* Use heap to not waste arena memory */
 		op_array->fn_flags |= ZEND_ACC_HEAP_RT_CACHE;
 

Zend/zend_opcode.c

@@ -567,6 +567,10 @@ ZEND_API void destroy_op_array(zend_op_array *op_array)
 		zend_string_release_ex(op_array->function_name, 0);
 	}
 
+	if (op_array->namespace_name) {
+		zend_string_release_ex(op_array->namespace_name, 0);
+	}
+
 	if (!op_array->refcount || --(*op_array->refcount) > 0) {
 		return;
 	}
@@ -612,9 +616,6 @@ ZEND_API void destroy_op_array(zend_op_array *op_array)
 	if (op_array->doc_comment) {
 		zend_string_release_ex(op_array->doc_comment, 0);
 	}
-	if (op_array->namespace_name) {
-		zend_string_release_ex(op_array->namespace_name, 0);
-	}
 	if (op_array->attributes) {
 		zend_hash_release(op_array->attributes);
 	}