Fix #71417: fread() does not report zlib.inflate errors

If the zlib.inflate filter fails to decompress the stream, we raise a
notice instead of failing silently.

Author: cmb69

NEWS

@@ -168,4 +168,7 @@ PHP                                                                        NEWS
   . Add ZipArchive::isCompressionMethodSupported() and
     ZipArchive::isEncryptionMethodSupported() method (libzip 1.7.0). (Remi)
 
+- Zlib:
+  . Fixed bug #71417 (fread() does not report zlib.inflate errors). (cmb)
+
 <<< NOTE: Insert NEWS from last stable release here prior to actual release! >>>

ext/standard/tests/filters/filter_errors_zlib_inflate.phpt

@@ -10,5 +10,9 @@ filter_errors_test('zlib.inflate', gzencode('42'));
 --EXPECTF--
 test filtering of buffered data
 
+Notice: stream_filter_append(): zlib: data error in %s on line %d
+
 Warning: stream_filter_append(): Filter failed to process pre-buffered data in %s
 test filtering of non buffered data
+
+Notice: stream_get_contents(): zlib: data error in %s on line %d

ext/zlib/tests/bug71417.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Bug #71417: fread() does not detect decoding errors from filter zlib.inflate
+Bug #71417: fread() does not report zlib.inflate errors
 --SKIPIF--
 <?php if (!extension_loaded('zlib')) die ('skip zlib extension not available in this build'); ?>
 --FILE--
@@ -69,6 +69,8 @@ test(4);
 gzdecode(): 
 Warning: gzdecode(): data error in %s on line %d
 
+
+Notice: fread(): zlib: data error in %s on line %d
 read: bool(false)
 gzdecode(): 
 Warning: gzdecode(): data error in %s on line %d
@@ -77,8 +79,12 @@ read: string(32) "The quick brown fox jumps over t"
 gzdecode(): 
 Warning: gzdecode(): data error in %s on line %d
 
+
+Notice: fread(): zlib: data error in %s on line %d
 read: bool(false)
 gzdecode(): 
 Warning: gzdecode(): data error in %s on line %d
 
+
+Notice: fread(): zlib: data error in %s on line %d
 read: bool(false)

ext/zlib/tests/bug_52944.phpt

@@ -18,7 +18,9 @@ var_dump(fread($fp,1));
 var_dump(fread($fp,1));
 fclose($fp);
 echo "Done.\n";
---EXPECT--
+?>
+--EXPECTF--
+Notice: fread(): zlib: data error in %s on line %d
 bool(false)
 string(0) ""
 Done.

ext/zlib/tests/zlib_filter_inflate2.phpt

@@ -33,7 +33,8 @@ fclose($fp);
 <?php
 @unlink(__DIR__ . '/test.txt.gz');
 ?>
---EXPECT--
+--EXPECTF--
+Notice: fread(): zlib: data error in %s on line %d
 1
 2
 This is quite the thing ain't it

ext/zlib/zlib_filter.c

@@ -90,6 +90,7 @@ static php_stream_filter_status_t php_zlib_inflate_filter(
 				exit_status = PSFS_PASS_ON;
 			} else if (status != Z_OK) {
 				/* Something bad happened */
+				php_error_docref(NULL, E_NOTICE, "zlib: %s", zError(status));
 				php_stream_bucket_delref(bucket);
 				/* reset these because despite the error the filter may be used again */
 				data->strm.next_in = data->inbuf;