Merge branch 'PHP-8.3' into PHP-8.4

ndossche · ndossche · commit 37a662058718 · 2025-11-06T22:42:44.000+01:00
* PHP-8.3:
  dom: Fix compile warning due to misplaced const cast
diff --git a/ext/dom/document.c b/ext/dom/document.c
@@ -1281,7 +1281,7 @@ PHP_METHOD(DOMDocument, __construct)
 	}
 
 	if (encoding_len > 0) {
-		docp->encoding = (const xmlChar *) xmlStrdup(BAD_CAST encoding);
+		docp->encoding = xmlStrdup((const xmlChar *) encoding);
 	}
 
 	intern = Z_DOMOBJ_P(ZEND_THIS);

Original file line number	Diff line number	Diff line change
`@@ -1281,7 +1281,7 @@ PHP_METHOD(DOMDocument, __construct)`
`1281`	`1281`	`}`
`1282`	`1282`
`1283`	`1283`	`if (encoding_len > 0) {`
`1284`		`- docp->encoding = (const xmlChar *) xmlStrdup(BAD_CAST encoding);`
	`1284`	`+ docp->encoding = xmlStrdup((const xmlChar *) encoding);`
`1285`	`1285`	`}`
`1286`	`1286`
`1287`	`1287`	`intern = Z_DOMOBJ_P(ZEND_THIS);`