pgsql: Fix memory leak when object init fails (#20387)

ndossche · web-flow · commit 04323955c1f7 · 2025-11-04T19:59:38.000+01:00
The return value is already overwritten by this point so we do have to
clean up the old return value (i.e. dataset) after all.
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
@@ -1875,6 +1875,7 @@ static void php_pgsql_fetch_hash(INTERNAL_FUNCTION_PARAMETERS, zend_long result_
 		ZVAL_COPY_VALUE(&dataset, return_value);
 		zend_result obj_initialized = object_init_ex(return_value, ce);
 		if (UNEXPECTED(obj_initialized == FAILURE)) {
+			zval_ptr_dtor(&dataset);
 			RETURN_THROWS();
 		}
 		if (!ce->default_properties_count && !ce->__set) {

Original file line number	Diff line number	Diff line change
`@@ -1875,6 +1875,7 @@ static void php_pgsql_fetch_hash(INTERNAL_FUNCTION_PARAMETERS, zend_long result_`
`1875`	`1875`	`ZVAL_COPY_VALUE(&dataset, return_value);`
`1876`	`1876`	`zend_result obj_initialized = object_init_ex(return_value, ce);`
`1877`	`1877`	`if (UNEXPECTED(obj_initialized == FAILURE)) {`
	`1878`	`+ zval_ptr_dtor(&dataset);`
`1878`	`1879`	`RETURN_THROWS();`
`1879`	`1880`	`}`
`1880`	`1881`	`if (!ce->default_properties_count && !ce->__set) {`