Skip to content

Commit 9a25b50

Browse files
authored
Fix psalm issues (#431)
* Typecast ->request->get() value to string * Fix PHP CS Fixer issue * Fix other psalm issues * Fix PHP CS Fixer issues one more time * Try to fix PhpStan issue
1 parent 31c841c commit 9a25b50

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

Controller/SymfonyProfilerController.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function editAction(Request $request, string $token): Response
6060
}
6161

6262
//Assert: This is a POST request
63-
$message->setTranslation($request->request->get('translation'));
63+
$message->setTranslation((string) $request->request->get('translation'));
6464
$this->storage->update($message->convertToMessage());
6565

6666
return new Response($message->getTranslation());
@@ -125,7 +125,7 @@ private function getMessage(Request $request, string $token): SfProfilerMessage
125125
{
126126
$this->profiler->disable();
127127

128-
$messageId = $request->request->get('message_id', $request->query->get('message_id'));
128+
$messageId = (string) $request->request->get('message_id', $request->query->get('message_id'));
129129

130130
$collectorMessages = $this->getMessages($token);
131131

@@ -154,8 +154,9 @@ protected function getSelectedMessages(Request $request, string $token): array
154154
{
155155
$this->profiler->disable();
156156

157-
$selected = $request->request->get('selected');
158-
if (!$selected || 0 == \count($selected)) {
157+
/** @var string[] $selected */
158+
$selected = (array) $request->request->get('selected');
159+
if (0 === \count($selected)) {
159160
return [];
160161
}
161162

phpstan-baseline.neon

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ parameters:
2525
count: 1
2626
path: Command/StatusCommand.php
2727

28-
-
29-
message: "#^Call to an undefined static method Symfony\\\\Component\\\\Intl\\\\Intl\\:\\:getLocaleBundle\\(\\)\\.$#"
30-
count: 1
31-
path: Controller/WebUIController.php
32-
3328
-
3429
message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\TreeBuilder\\:\\:root\\(\\)\\.$#"
3530
count: 1

0 commit comments

Comments
 (0)