Remove Twig deprecations

Author: ZZromanZZ

Twig/Visitor/DefaultApplyingNodeVisitor.php

@@ -21,7 +21,7 @@
 use Twig\Node\Expression\Ternary\ConditionalTernary;
 use Twig\Node\Node;
 use Twig\Node\Nodes;
-use Twig\NodeVisitor\AbstractNodeVisitor;
+use Twig\NodeVisitor\NodeVisitorInterface;
 use Twig\TwigFilter;
 
 /**
@@ -32,7 +32,7 @@
  *
  * @author Johannes M. Schmitt <schmittjoh@gmail.com>
  */
-final class DefaultApplyingNodeVisitor extends AbstractNodeVisitor
+final class DefaultApplyingNodeVisitor implements NodeVisitorInterface
 {
     /**
      * @var bool
@@ -50,14 +50,14 @@ public function doEnterNode(Node $node, Environment $env): Node
             return $node;
         }
 
-        if (!($node instanceof FilterExpression && 'desc' === $node->getNode('filter')->getAttribute('value'))) {
+        if (!($node instanceof FilterExpression && 'desc' === $node->getAttribute('twig_callable')->getName())) {
             return $node;
         }
 
         $transNode = $node->getNode('node');
         while ($transNode instanceof FilterExpression
-                   && 'trans' !== $transNode->getNode('filter')->getAttribute('value')
-                   && 'transchoice' !== $transNode->getNode('filter')->getAttribute('value')) {
+                   && 'trans' !== $transNode->getAttribute('twig_callable')->getName()
+                   && 'transchoice' !== $transNode->getAttribute('twig_callable')->getName()) {
             $transNode = $transNode->getNode('node');
         }
 
@@ -72,7 +72,7 @@ public function doEnterNode(Node $node, Environment $env): Node
         // if the |transchoice filter is used, delegate the call to the TranslationExtension
         // so that we can catch a possible exception when the default translation has not yet
         // been extracted
-        if ('transchoice' === $transNode->getNode('filter')->getAttribute('value')) {
+        if ('transchoice' === $transNode->getAttribute('twig_callable')->getName()) {
             $transchoiceArguments = new ArrayExpression([], $transNode->getTemplateLine());
             $transchoiceArguments->addElement($wrappingNode->getNode('node'));
             $transchoiceArguments->addElement($defaultNode);
@@ -150,4 +150,14 @@ public function getPriority(): int
     {
         return -2;
     }
+
+    public function enterNode(Node $node, Environment $env): Node
+    {
+        return $this->doEnterNode($node, $env);
+    }
+
+    public function leaveNode(Node $node, Environment $env): ?Node
+    {
+        return $this->doLeaveNode($node, $env);
+    }
 }

Twig/Visitor/RemovingNodeVisitor.php

@@ -14,14 +14,14 @@
 use Twig\Environment;
 use Twig\Node\Expression\FilterExpression;
 use Twig\Node\Node;
-use Twig\NodeVisitor\AbstractNodeVisitor;
+use Twig\NodeVisitor\NodeVisitorInterface;
 
 /**
  * Removes translation metadata filters from the AST.
  *
  * @author Johannes M. Schmitt <schmittjoh@gmail.com>
  */
-final class RemovingNodeVisitor extends AbstractNodeVisitor
+final class RemovingNodeVisitor implements NodeVisitorInterface
 {
     /**
      * @var bool
@@ -36,7 +36,7 @@ public function setEnabled(bool $bool): void
     protected function doEnterNode(Node $node, Environment $env): Node
     {
         if ($this->enabled && $node instanceof FilterExpression) {
-            $name = $node->getNode('filter')->getAttribute('value');
+            $name = $node->getAttribute('twig_callable')->getName();
 
             if ('desc' === $name || 'meaning' === $name) {
                 return $this->enterNode($node->getNode('node'), $env);
@@ -55,4 +55,14 @@ public function getPriority(): int
     {
         return -1;
     }
+
+    public function enterNode(Node $node, Environment $env): Node
+    {
+        return $this->doEnterNode($node, $env);
+    }
+
+    public function leaveNode(Node $node, Environment $env): ?Node
+    {
+        return $this->doLeaveNode($node, $env);
+    }
 }

composer.json

@@ -22,7 +22,7 @@
         "php-translation/symfony-storage": "^2.1",
         "php-translation/extractor": "^2.0",
         "nyholm/nsa": "^1.1",
-        "twig/twig": "^3.3",
+        "twig/twig": "^3.12",
         "symfony/asset": "^5.3 || ^6.0 || ^7.0"
     },
     "require-dev": {