Make sure we dont use unique strings. They are impossible to cache (#279)

Nyholm · bocharsky-bw · commit 62d0029b2dbf · 2019-06-26T10:46:25.000+03:00
diff --git a/Translator/FallbackTranslator.php b/Translator/FallbackTranslator.php
@@ -145,7 +145,7 @@ private function translateWithSubstitutedParameters($orgString, $locale, array $
         // Replace parameters
         $replacements = [];
         foreach ($parameters as $placeholder => $nonTranslatableValue) {
-            $replacements[(string) $nonTranslatableValue] = uniqid();
+            $replacements[(string) $nonTranslatableValue] = sha1($placeholder);
         }
 
         $replacedString = str_replace(array_keys($replacements), array_values($replacements), $orgString);

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ private function translateWithSubstitutedParameters($orgString, $locale, array $`
`145`	`145`	`// Replace parameters`
`146`	`146`	`$replacements = [];`
`147`	`147`	`foreach ($parameters as $placeholder => $nonTranslatableValue) {`
`148`		`- $replacements[(string) $nonTranslatableValue] = uniqid();`
	`148`	`+ $replacements[(string) $nonTranslatableValue] = sha1($placeholder);`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`$replacedString = str_replace(array_keys($replacements), array_values($replacements), $orgString);`