fix: Str.toNoEmptyArray split error on contains special chars

Author: inhere

src/Str/Traits/StringConvertTrait.php

@@ -22,6 +22,7 @@
 use function mb_convert_variables;
 use function mb_detect_encoding;
 use function mb_strwidth;
+use function preg_quote;
 use function preg_split;
 use function str_contains;
 use function str_pad;
@@ -30,6 +31,7 @@
 use function strlen;
 use function strpos;
 use function trim;
+use function vdump;
 use const PREG_SPLIT_NO_EMPTY;
 
 /**
@@ -235,7 +237,12 @@ public static function toNoEmptyArray(string $str, string $sep = ',', int $limit
             return [];
         }
 
-        $pattern = $sep === ' ' ? '/\s+/' : "/\s*$sep\s*/";
+        if ($sep === ' ') {
+            $pattern = '/\s+/';
+        } else {
+            $pattern = '/\s*' . preg_quote($sep, '/') . '\s*/';
+        }
+
         return preg_split($pattern, $str, $limit, PREG_SPLIT_NO_EMPTY);
     }
 

test/Str/StringHelperTest.php

@@ -104,6 +104,21 @@ public function testStrpos(): void
         self::assertFalse(Str::notContains('abc', 'b'));
     }
 
+    public function testToNoEmptyArray(): void
+    {
+        $tests = [
+            ['ab, cd', ',', ['ab', 'cd']],
+            ['ab / cd', '/', ['ab', 'cd']],
+            ['ab | cd', '|', ['ab', 'cd']],
+            [' fieldName   some  desc', ' ', ['fieldName', 'some', 'desc']],
+            [' ab   0  cd ', ' ', ['ab', '0', 'cd']],
+        ];
+
+        foreach ($tests as [$given, $sep, $want]) {
+            $this->assertEquals($want, Str::toNoEmptyArray($given, $sep));
+        }
+    }
+
     public function testToArray_no_limit(): void
     {
         $tests = [