fix parse flag error

Author: inhere

src/Flags.php

@@ -195,7 +195,12 @@ public static function parseArgv(array $params, array $config = []): array
             // value specified inline (<arg>=<value>)
             if (strpos($p, '=') !== false) {
                 [$name, $value] = explode('=', $p, 2);
-                $args[$name] = self::filterBool($value);
+
+                if (self::isValidArgName($name)) {
+                    $args[$name] = self::filterBool($value);
+                } else {
+                    $args[] = $p;
+                }
             } else {
                 $args[] = $p;
             }
@@ -314,6 +319,16 @@ public static function nextIsValue($val): bool
         return $val[0] !== '-' && false === strpos($val, '=');
     }
 
+    /**
+     * @param string $name
+     *
+     * @return bool
+     */
+    public static function isValidArgName(string $name): bool
+    {
+        return preg_match('#^\w+$#', $name) === 1;
+    }
+
     /**
      * Escapes a token through escapeshellarg if it contains unsafe chars.
      *

test/FlagsTest.php

@@ -10,8 +10,8 @@
 namespace Toolkit\CliTest;
 
 use PHPUnit\Framework\TestCase;
-use function explode;
 use Toolkit\Cli\Flags;
+use function explode;
 
 /**
  * Class FlagsTest
@@ -42,4 +42,32 @@ public function testParseArgv(): void
         $this->assertSame('../view', $opts['d']);
         $this->assertTrue($opts['only-tag']);
     }
+
+    public function testParseInvalidArgName(): void
+    {
+        [$args, , ] = Flags::parseArgv([
+            'cmd',
+            'http://some.com/path/to/merge_requests/new?utf8=%E2%9C%93&merge_request%5Bsource_project_id%5D=319'
+        ]);
+
+        $this->assertSame('cmd', $args[0]);
+        $this->assertSame('http://some.com/path/to/merge_requests/new?utf8=%E2%9C%93&merge_request%5Bsource_project_id%5D=319', $args[1]);
+    }
+
+    public function testisParseWithSpace(): void
+    {
+        [$args, , ] = Flags::parseArgv([
+            'cmd',
+            ' -'
+        ]);
+
+        $this->assertSame('cmd', $args[0]);
+        $this->assertSame(' -', $args[1]);
+    }
+
+    public function testisValidArgName(): void
+    {
+        $this->assertTrue(Flags::isValidArgName('arg0'));
+        $this->assertFalse(Flags::isValidArgName('/path/to'));
+    }
 }