code style changes

Author: Masiukevich Maksim

phpunit.xml

@@ -16,8 +16,14 @@
         <ini name="error_reporting" value="-1"/>
     </php>
     <testsuites>
+
+        <testsuite name="Component: common">
+            <directory>./vendor/php-service-bus/common/tests/</directory>
+        </testsuite>
+
         <testsuite name="Message serializer component">
             <directory>./tests/</directory>
         </testsuite>
+
     </testsuites>
 </phpunit>

src/Symfony/Extensions/EmptyDataNormalizer.php

@@ -26,17 +26,13 @@ final class EmptyDataNormalizer implements NormalizerInterface, DenormalizerInte
      */
     private $localStorage = [];
 
-    /**
-     * {@inheritdoc}
-     */
+
     public function normalize($object, string $format = null, array $context = []): array
     {
         return [];
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @throws \ReflectionException
      */
     public function supportsNormalization($data, string $format = null): bool
@@ -63,8 +59,6 @@ static function (\ReflectionProperty $property): string
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @throws \ServiceBus\Common\Exceptions\ReflectionApiException
      */
     public function denormalize($data, string $type, string $format = null, array $context = []): object
@@ -74,9 +68,6 @@ public function denormalize($data, string $type, string $format = null, array $c
         return createWithoutConstructor($type);
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function supportsDenormalization($data, string $type, string $format = null): bool
     {
         return empty($data);

src/Symfony/Extensions/PropertyNameConverter.php

@@ -26,17 +26,11 @@ final class PropertyNameConverter implements NameConverterInterface
      */
     private $localStorage = [];
 
-    /**
-     * {@inheritdoc}
-     */
     public function normalize(string $propertyName): string
     {
         return $propertyName;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function denormalize(string $propertyName): string
     {
         if (isset($this->localStorage[$propertyName]) === false)

src/Symfony/Extensions/PropertyNormalizerWrapper.php

@@ -27,8 +27,6 @@ final class PropertyNormalizerWrapper extends PropertyNormalizer
     private $localStorage = [];
 
     /**
-     * {@inheritdoc}
-     *
      * @param array|bool $allowedAttributes
      *
      * @throws \ReflectionException
@@ -45,9 +43,6 @@ protected function instantiateObject(
         return $reflectionClass->newInstanceWithoutConstructor();
     }
 
-    /**
-     * {@inheritdoc}
-     */
     protected function extractAttributes(object $object, string $format = null, array $context = []): array
     {
         $class = \get_class($object);
@@ -61,8 +56,6 @@ protected function extractAttributes(object $object, string $format = null, arra
     }
 
     /**
-     * {@inheritdoc}
-     *
      * @throws \Error
      */
     protected function getAttributeValue(object $object, string $attribute, string $format = null, array $context = [])
@@ -72,8 +65,6 @@ protected function getAttributeValue(object $object, string $attribute, string $
 
     /**
      * @psalm-param mixed $value
-     *
-     * {@inheritdoc}
      */
     protected function setAttributeValue(object $object, string $attribute, $value, string $format = null, array $context = []): void
     {

src/Symfony/Extractor/CombinedExtractor.php

@@ -21,13 +21,19 @@
  */
 final class CombinedExtractor implements PropertyTypeExtractorInterface
 {
-    /** @psalm-var array<string, \Symfony\Component\PropertyInfo\Type[]|null> */
+    /**
+     * @psalm-var array<string, \Symfony\Component\PropertyInfo\Type[]|null>
+     */
     private $localStorage = [];
 
-    /** @var PhpDocExtractor */
+    /**
+     * @var PhpDocExtractor
+     */
     private $phpDocExtractor;
 
-    /** @var ReflectionExtractor */
+    /**
+     * @var ReflectionExtractor
+     */
     private $reflectionPropertyExtractor;
 
     public function __construct()
@@ -36,9 +42,6 @@ public function __construct()
         $this->reflectionPropertyExtractor = new ReflectionExtractor();
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getTypes(string $class, string $property, array $context = []): ?array
     {
         $cacheKey = $class . $property;

src/Symfony/SymfonySerializer.php

@@ -22,7 +22,6 @@
 use ServiceBus\MessageSerializer\Symfony\Extensions\PropertyNameConverter;
 use ServiceBus\MessageSerializer\Symfony\Extensions\PropertyNormalizerWrapper;
 use ServiceBus\MessageSerializer\Symfony\Extractor\CombinedExtractor;
-use Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor;
 use Symfony\Component\Serializer;
 use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
 use function ServiceBus\Common\jsonDecode;
@@ -45,7 +44,7 @@ final class SymfonySerializer implements MessageEncoder, MessageDecoder
      */
     public function __construct(array $normalizers = [])
     {
-        $extractor = \PHP_VERSION_ID >= 70400 ? new CombinedExtractor() : new PhpDocExtractor();
+        $extractor = new CombinedExtractor();
 
         $defaultNormalizers = [
             new DateTimeNormalizer(['datetime_format' => 'c']),

tests/Symfony/SymfonyMessageSerializerTest.php

@@ -1,4 +1,4 @@
-<?php
+<?php /** @noinspection PhpUnhandledExceptionInspection */
 
 /**
  * Messages serializer implementation.
@@ -35,8 +35,6 @@ final class SymfonyMessageSerializerTest extends TestCase
 {
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function emptyClassWithClosedConstructor(): void
     {
@@ -51,8 +49,6 @@ public function emptyClassWithClosedConstructor(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public static function classWithClosedConstructor(): void
     {
@@ -72,8 +68,6 @@ public static function classWithClosedConstructor(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function withDateTime(): void
     {
@@ -91,8 +85,6 @@ public function withDateTime(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function wthNullableObjectArgument(): void
     {
@@ -125,8 +117,6 @@ public function wthNullableObjectArgument(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function denormalizeToUnknownClass(): void
     {
@@ -139,8 +129,6 @@ public function denormalizeToUnknownClass(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function withWrongCharset(): void
     {
@@ -156,8 +144,6 @@ public function withWrongCharset(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function successFlow(): void
     {
@@ -183,8 +169,6 @@ public function successFlow(): void
 
     /**
      * @test
-     *
-     * @throws \Throwable
      */
     public function successCollection(): void
     {
@@ -217,10 +201,6 @@ static function (Author $author): string
 
     /**
      * @test
-     *
-     * @requires PHP >= 7.4
-     *
-     * @throws \Throwable
      */
     public function legacyPropertiesSupport(): void
     {
@@ -241,10 +221,6 @@ public function legacyPropertiesSupport(): void
 
     /**
      * @test
-     *
-     * @requires PHP >= 7.4
-     *
-     * @throws \Throwable
      */
     public function privateMixedPropertiesSupport(): void
     {