Implement - WIP

Author: SOHELAHMED7

src/lib/migrations/BaseMigrationBuilder.php

@@ -199,9 +199,10 @@ function (string $unknownColumn) {
 
         $columnsForChange = array_intersect($wantNames, $haveNames);
 
+        $columnsForRename = $this->findColumnsToRename($columnsForCreate, $columnsForDrop, $this->newColumns);
+
         if ($this->model->drop) {
             $this->newColumns = [];
-            $wantNames = [];
             $columnsForCreate = [];
             $columnsForChange = [];
             $columnsForDrop = [];
@@ -614,4 +615,26 @@ protected function shouldCompareComment(ColumnSchema $desired): bool
         }
         return $comment;
     }
+
+    /**
+     * @param array $columnsForCreate
+     * @param array $columnsForDrop
+     * @param $newColumns
+     * @return string[]
+     */
+    public function findColumnsToRename(array &$columnsForCreate, array &$columnsForDrop, $newColumns): array
+    {
+        $columnNames = [];
+        $existingColumns = $this->tableSchema->columns;
+        $existingColumnNames = array_flip(array_keys($existingColumns));
+        $newColumnNames = array_flip(array_keys($newColumns));
+
+        foreach ($columnsForCreate as $name) {
+            if ($existingColumnNames[$name] === $newColumnNames[$name]) {
+                // TODO compare column
+            }
+        }
+
+        return $columnNames;
+    }
 }

tests/specs/issue_fix/63_just_column_name_rename/index.php

@@ -0,0 +1,13 @@
+<?php
+
+return [
+    'openApiPath' => '@specs/issue_fix/63_just_column_name_rename/index.yml',
+    'generateUrls' => false,
+    'generateModels' => false,
+    'excludeModels' => [
+        'Error',
+    ],
+    'generateControllers' => false,
+    'generateMigrations' => true,
+    'generateModelFaker' => false, // `generateModels` must be `true` in order to use `generateModelFaker` as `true`
+];

tests/specs/issue_fix/63_just_column_name_rename/index.yml

@@ -0,0 +1,49 @@
+openapi: 3.0.3
+x-description-is-comment: true
+info:
+  title: 'Description of a property in spec must correspond to DB TABLE COLUMN COMMENT #60'
+  version: 1.0.0
+
+components:
+  schemas:
+    Fruit:
+      type: object
+      properties:
+        id:
+          type: integer
+        name:
+          type: string
+          description: desc with ' quote
+        description:
+          type: number
+          x-db-type: double precision
+          description: desc ' 2
+    Animal:
+      type: object
+      properties:
+        id:
+          type: integer
+        name:
+          type: integer
+        g:
+          type: string
+          description: desc for g
+        g2:
+          type: string
+          description: changed comment on g2 col
+        g3:
+          type: string
+          description: the comment on g3 col remains same
+        g4:
+          type: integer
+          description: data type changes but comment remains same
+        new_col:
+          type: string
+          description: new col added
+
+paths:
+  '/':
+    get:
+      responses:
+        '200':
+          description: OK

tests/unit/IssueFixTest.php

@@ -885,4 +885,24 @@ public function test25GenerateInverseRelations()
         ]);
         $this->checkFiles($actualFiles, $expectedFiles);
     }
+
+    // https://github.com/php-openapi/yii2-openapi/issues/63
+    public function test63JustColumnNameRename()
+    {
+        $this->assertTrue(4);
+
+        return;
+        
+
+        $testFile = Yii::getAlias("@specs/issue_fix/63_just_column_name_rename/index.php");
+        $this->runGenerator($testFile);
+        $this->runActualMigrations('mysql', 1);
+        $actualFiles = FileHelper::findFiles(Yii::getAlias('@app'), [
+            'recursive' => true,
+        ]);
+        $expectedFiles = FileHelper::findFiles(Yii::getAlias("@specs/issue_fix/63_just_column_name_rename/mysql"), [
+            'recursive' => true,
+        ]);
+        $this->checkFiles($actualFiles, $expectedFiles);
+    }
 }