Refactor

Author: SOHELAHMED7

src/generator/ApiGenerator.php

@@ -541,7 +541,7 @@ public static function removeDuplicateActions(array $actions): array
 
         $actions = array_map(function ($action) {
             /** @var $action RestAction|FractalAction */
-            if ($action instanceof RestAction && $action->isOriginalForCustomRoute) {
+            if ($action instanceof RestAction && $action->zeroParams) {
                 $action->idParam = null;
                 $action->params = [];
             }

src/lib/generators/RestActionGenerator.php

@@ -82,8 +82,8 @@ protected function resolvePath(string $path, PathItem $pathItem):array
             if ($customRoute !== null) {
                 if (in_array($customRoute, array_keys($this->allCustomRoutes))) {
                     $action->isDuplicate = true;
-                    if ($action->params !== $this->allCustomRoutes[$customRoute]) {
-                        $this->allCustomRoutes[$customRoute]->isOriginalForCustomRoute = true;
+                    if ($action->params !== $this->allCustomRoutes[$customRoute]->params) {
+                        $this->allCustomRoutes[$customRoute]->zeroParams = true;
                     }
                 } else {
                     $action->isDuplicate = false;

src/lib/items/RestAction.php

@@ -74,15 +74,15 @@ final class RestAction extends BaseObject
      * https://github.com/cebe/yii2-openapi/issues/84
      * see `x-route` in README.md
      * Used for generating only one action for paths like: `GET /calendar/domains` and `GET /calendar/domains/{id}` given that they have same `x-route`.
-     * This is used to flag first of one or more duplicates
+     * If duplicates routes have same params then `false`, else action is generated with no (0) params `true`
      */
-    public $isOriginalForCustomRoute = false;
+    public $zeroParams = false;
 
     /**
      * @var bool
      * https://github.com/cebe/yii2-openapi/issues/84
      * Generate only one action for paths like: `GET /calendar/domains` and `GET /calendar/domains/{id}` given that they have same `x-route`.
-     * @see $isOriginalForCustomRoute
+     * @see $zeroParams
      * see `x-route` in README.md
      */
     public $isDuplicate = false;