Use sys_get_temp_dir() rather than mkdir for temporary files

Florian Pisani · Florian Pisani · commit af4fd6aaa482 · 2021-05-28T14:25:33.000+02:00
diff --git a/src/UploadedFileIntegrationTest.php b/src/UploadedFileIntegrationTest.php
@@ -27,7 +27,6 @@ abstract public function createSubject();
 
     public static function setUpBeforeClass(): void
     {
-        @mkdir('.tmp');
         parent::setUpBeforeClass();
     }
 
@@ -56,7 +55,7 @@ public function testGetStreamAfterMoveTo()
 
         $file = $this->createSubject();
         $this->expectException(\RuntimeException::class);
-        $file->moveTo(sys_get_temp_dir().'/foo');
+        $file->moveTo(sys_get_temp_dir().'/'.uniqid('foo', true));
         $file->getStream();
     }
 
@@ -81,7 +80,7 @@ public function testMoveToRelative()
         }
 
         $file = $this->createSubject();
-        $targetPath = '.tmp/'.uniqid('foo', true);
+        $targetPath = sys_get_temp_dir().'/'.uniqid('foo', true);
 
         $this->assertFalse(is_file($targetPath));
         $file->moveTo($targetPath);
@@ -96,8 +95,8 @@ public function testMoveToTwice()
         $this->expectException(\RuntimeException::class);
 
         $file = $this->createSubject();
-        $file->moveTo('.tmp/'.uniqid('foo', true));
-        $file->moveTo('.tmp/'.uniqid('foo', true));
+        $file->moveTo(sys_get_temp_dir().'/'.uniqid('foo', true));
+        $file->moveTo(sys_get_temp_dir().'/'.uniqid('foo', true));
     }
 
     public function testGetSize()

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ abstract public function createSubject();`
`27`	`27`
`28`	`28`	`public static function setUpBeforeClass(): void`
`29`	`29`	`{`
`30`		`- @mkdir('.tmp');`
`31`	`30`	`parent::setUpBeforeClass();`
`32`	`31`	`}`
`33`	`32`
`@@ -56,7 +55,7 @@ public function testGetStreamAfterMoveTo()`
`56`	`55`
`57`	`56`	`$file = $this->createSubject();`
`58`	`57`	`$this->expectException(\RuntimeException::class);`
`59`		`- $file->moveTo(sys_get_temp_dir().'/foo');`
	`58`	`+ $file->moveTo(sys_get_temp_dir().'/'.uniqid('foo', true));`
`60`	`59`	`$file->getStream();`
`61`	`60`	`}`
`62`	`61`
`@@ -81,7 +80,7 @@ public function testMoveToRelative()`
`81`	`80`	`}`
`82`	`81`
`83`	`82`	`$file = $this->createSubject();`
`84`		`- $targetPath = '.tmp/'.uniqid('foo', true);`
	`83`	`+ $targetPath = sys_get_temp_dir().'/'.uniqid('foo', true);`
`85`	`84`
`86`	`85`	`$this->assertFalse(is_file($targetPath));`
`87`	`86`	`$file->moveTo($targetPath);`
`@@ -96,8 +95,8 @@ public function testMoveToTwice()`
`96`	`95`	`$this->expectException(\RuntimeException::class);`
`97`	`96`
`98`	`97`	`$file = $this->createSubject();`
`99`		`- $file->moveTo('.tmp/'.uniqid('foo', true));`
`100`		`- $file->moveTo('.tmp/'.uniqid('foo', true));`
	`98`	`+ $file->moveTo(sys_get_temp_dir().'/'.uniqid('foo', true));`
	`99`	`+ $file->moveTo(sys_get_temp_dir().'/'.uniqid('foo', true));`
`101`	`100`	`}`
`102`	`101`
`103`	`102`	`public function testGetSize()`