Merge pull request #148 from php-http/fix-php8-test

dbu · web-flow · commit 1ca05db9779f · 2022-02-11T14:31:06.000+01:00
php 8 seems to behave the same as php 7
diff --git a/spec/Encoding/FilteredStreamStubSpec.php b/spec/Encoding/FilteredStreamStubSpec.php
@@ -12,22 +12,14 @@ function it_throws_during_instantiation_with_invalid_read_filter_options(StreamI
     {
         $this->beAnInstanceOf('spec\Http\Message\Encoding\FilteredStreamStub');
         $this->beConstructedWith($stream, 'foo');
-        if (\PHP_MAJOR_VERSION < 8) {
-            $this->shouldThrow('RuntimeException')->duringInstantiation();
-        } else {
-            $this->shouldThrow('PhpSpec\Exception\Example\ErrorException')->duringInstantiation();
-        }
+        $this->shouldThrow('RuntimeException')->duringInstantiation();
     }
 
     function it_throws_during_instantiation_with_invalid_write_filter_options(StreamInterface $stream)
     {
         $this->beAnInstanceOf('spec\Http\Message\Encoding\FilteredStreamStub');
         $this->beConstructedWith($stream, null, 'foo');
-        if (\PHP_MAJOR_VERSION < 8) {
-            $this->shouldThrow('RuntimeException')->duringInstantiation();
-        } else {
-            $this->shouldThrow('PhpSpec\Exception\Example\ErrorException')->duringInstantiation();
-        }
+        $this->shouldThrow('RuntimeException')->duringInstantiation();
     }
 
     function let(StreamInterface $stream)

Original file line number	Diff line number	Diff line change
`@@ -12,22 +12,14 @@ function it_throws_during_instantiation_with_invalid_read_filter_options(StreamI`
`12`	`12`	`{`
`13`	`13`	`$this->beAnInstanceOf('spec\Http\Message\Encoding\FilteredStreamStub');`
`14`	`14`	`$this->beConstructedWith($stream, 'foo');`
`15`		`- if (\PHP_MAJOR_VERSION < 8) {`
`16`		`- $this->shouldThrow('RuntimeException')->duringInstantiation();`
`17`		`- } else {`
`18`		`- $this->shouldThrow('PhpSpec\Exception\Example\ErrorException')->duringInstantiation();`
`19`		`- }`
	`15`	`+ $this->shouldThrow('RuntimeException')->duringInstantiation();`
`20`	`16`	`}`
`21`	`17`
`22`	`18`	`function it_throws_during_instantiation_with_invalid_write_filter_options(StreamInterface $stream)`
`23`	`19`	`{`
`24`	`20`	`$this->beAnInstanceOf('spec\Http\Message\Encoding\FilteredStreamStub');`
`25`	`21`	`$this->beConstructedWith($stream, null, 'foo');`
`26`		`- if (\PHP_MAJOR_VERSION < 8) {`
`27`		`- $this->shouldThrow('RuntimeException')->duringInstantiation();`
`28`		`- } else {`
`29`		`- $this->shouldThrow('PhpSpec\Exception\Example\ErrorException')->duringInstantiation();`
`30`		`- }`
	`22`	`+ $this->shouldThrow('RuntimeException')->duringInstantiation();`
`31`	`23`	`}`
`32`	`24`
`33`	`25`	`function let(StreamInterface $stream)`