ci: add tests for PHP 8.5 #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump checkout action 4 => 5
Contributor
|
uh, that build pipeline (and probably the code) needs some more love apart from php 8.5. do you have time to look at it? i am open to ditch old php versions, people can just keep using 1.1.0 if they are stuck on legacy PHP. |
Contributor
Author
|
Step 1: Allow PHPUnit > 9 after php-http/client-integration-tests#61 is merged. |
Contributor
Author
|
Which PHP version should it be bumped to? 8.1 ? |
Contributor
if 8.0 just works we can also keep supporting it for now. maybe you can disable the fail_fast option so we see what is going on. and once the build with newer php versions works again, we can remove all that don't work but keep those that do work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump checkout action 4 => 5