Skip to content

Conversation

@Chris53897
Copy link
Contributor

CI check

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we indeed should allow those versions. can you please check the build errors? we seem to have some backward compatible trait that now collides with the newer versions.

Co-authored-by: David Buchmann <david@liip.ch>
@Chris53897
Copy link
Contributor Author

i will have a look

@Chris53897 Chris53897 closed this Nov 11, 2025
@Chris53897 Chris53897 reopened this Nov 11, 2025
@Chris53897
Copy link
Contributor Author

@dbu This is read to review

The 3 failing tests are the same without bumping PHPUnit #62
These should be handled in seperate PRs in my point of view.

@Chris53897 Chris53897 closed this Nov 11, 2025
@Chris53897 Chris53897 reopened this Nov 11, 2025
@Chris53897 Chris53897 mentioned this pull request Nov 11, 2025
@dbu dbu merged commit 166a7e1 into php-http:3.x Nov 11, 2025
6 of 9 checks passed
@dbu
Copy link
Contributor

dbu commented Nov 11, 2025

thanks a lot for this cleanup!

@Chris53897 Chris53897 deleted the feature/phpunit branch November 11, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants