Merge pull request #34 from php-http/analysis-Xp1k0L

Apply fixes from StyleCI

Author: dbu

src/HttpAsyncClientTest.php

@@ -95,7 +95,7 @@ public function testSuccessiveInvalidCallMustUseException()
      */
     public function testAsyncSendRequest($method, $uri, array $headers, $body)
     {
-        if ($body != null) {
+        if (null != $body) {
             $headers['Content-Length'] = (string) strlen($body);
         }
 
@@ -120,7 +120,7 @@ public function testAsyncSendRequest($method, $uri, array $headers, $body)
         $this->assertResponse(
             $response,
             [
-                'body' => $method === 'HEAD' ? null : 'Ok',
+                'body' => 'HEAD' === $method ? null : 'Ok',
             ]
         );
         $this->assertRequest($method, $headers, $body, '1.1');
@@ -164,11 +164,11 @@ public function testSendAsyncWithInvalidUri()
      */
     public function testSendAsyncRequestWithOutcome($uriAndOutcome, $protocolVersion, array $headers, $body)
     {
-        if ($protocolVersion === '1.0') {
+        if ('1.0' === $protocolVersion) {
             $body = null;
         }
 
-        if ($body != null) {
+        if (null != $body) {
             $headers['Content-Length'] = (string) strlen($body);
         }
 

src/HttpBaseTest.php

@@ -77,7 +77,7 @@ public function requestProvider()
 
         // Filter all TRACE requests with a body, as they're not HTTP spec compliant
         return array_filter($cases, function ($case) {
-            if ($case[0] === 'TRACE' && $case[3] !== null) {
+            if ('TRACE' === $case[0] && null !== $case[3]) {
                 return false;
             }
 
@@ -232,7 +232,7 @@ protected function assertResponse($response, array $options = [])
             $this->assertStringStartsWith($value, $response->getHeaderLine($name));
         }
 
-        if ($options['body'] === null) {
+        if (null === $options['body']) {
             $this->assertEmpty($response->getBody()->getContents());
         } else {
             $this->assertContains($options['body'], $response->getBody()->getContents());
@@ -270,7 +270,7 @@ protected function assertRequest(
 
             $name = strtoupper(str_replace('-', '_', 'http-'.$name));
 
-            if ($method === 'TRACE' && $name === 'HTTP_CONTENT_LENGTH' && !isset($request['SERVER'][$name])) {
+            if ('TRACE' === $method && 'HTTP_CONTENT_LENGTH' === $name && !isset($request['SERVER'][$name])) {
                 continue;
             }
 

src/HttpClientTest.php

@@ -41,7 +41,7 @@ abstract protected function createHttpAdapter();
      */
     public function testSendRequest($method, $uri, array $headers, $body)
     {
-        if ($body != null) {
+        if (null != $body) {
             $headers['Content-Length'] = (string) strlen($body);
         }
 
@@ -57,7 +57,7 @@ public function testSendRequest($method, $uri, array $headers, $body)
         $this->assertResponse(
             $response,
             [
-                'body' => $method === 'HEAD' ? null : 'Ok',
+                'body' => 'HEAD' === $method ? null : 'Ok',
             ]
         );
         $this->assertRequest($method, $headers, $body, '1.1');
@@ -69,11 +69,11 @@ public function testSendRequest($method, $uri, array $headers, $body)
      */
     public function testSendRequestWithOutcome($uriAndOutcome, $protocolVersion, array $headers, $body)
     {
-        if ($protocolVersion === '1.0') {
+        if ('1.0' === $protocolVersion) {
             $body = null;
         }
 
-        if ($body != null) {
+        if (null != $body) {
             $headers['Content-Length'] = (string) strlen($body);
         }
 

src/PHPUnitUtility.php

@@ -29,6 +29,6 @@ public static function getUri()
      */
     public static function getFile($tmp = true, $name = null)
     {
-        return ($tmp ? realpath(sys_get_temp_dir()) : '').'/'.($name === null ? uniqid() : $name);
+        return ($tmp ? realpath(sys_get_temp_dir()) : '').'/'.(null === $name ? uniqid() : $name);
     }
 }