Merge pull request #373 from php-http/symfony-facotry

Add a Symfony client factory

Author: dbu

.travis.yml

@@ -39,9 +39,9 @@ matrix:
         - php: 7.3
           env: SYMFONY_REQUIRE=4.3.*
         - php: 7.3
-          env: SYMFONY_REQUIRE=4.4.*
+          env: SYMFONY_REQUIRE=4.4.* DEPENDENCIES="symfony/http-client:^4.4"
         - php: 7.3
-          env: SYMFONY_REQUIRE=5.0.*
+          env: SYMFONY_REQUIRE=5.0.* DEPENDENCIES="symfony/http-client:^5.0"
 
           # Test with httplug 1.x clients
         - php: 7.2

src/ClientFactory/SymfonyFactory.php

@@ -0,0 +1,46 @@
+<?php
+
+namespace Http\HttplugBundle\ClientFactory;
+
+use Psr\Http\Message\ResponseFactoryInterface;
+use Psr\Http\Message\StreamFactoryInterface;
+use Symfony\Component\HttpClient\HttpClient;
+use Symfony\Component\HttpClient\HttplugClient;
+
+/**
+ * @author Tobias Nyholm <tobias.nyholm@gmail.com>
+ */
+class SymfonyFactory implements ClientFactory
+{
+    /**
+     * @var ResponseFactoryInterface
+     */
+    private $responseFactory;
+
+    /**
+     * @var StreamFactoryInterface
+     */
+    private $streamFactory;
+
+    /**
+     * @param ResponseFactoryInterface $responseFactory
+     * @param StreamFactoryInterface   $streamFactory
+     */
+    public function __construct(ResponseFactoryInterface $responseFactory, StreamFactoryInterface $streamFactory)
+    {
+        $this->responseFactory = $responseFactory;
+        $this->streamFactory = $streamFactory;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function createClient(array $config = [])
+    {
+        if (!class_exists(HttplugClient::class)) {
+            throw new \LogicException('To use the Symfony client you need to install the "symfony/http-client" package.');
+        }
+
+        return new HttplugClient(HttpClient::create($config), $this->responseFactory, $this->streamFactory);
+    }
+}

src/Resources/config/services.xml

@@ -93,5 +93,9 @@
         <service id="httplug.factory.socket" class="Http\HttplugBundle\ClientFactory\SocketFactory" public="false">
             <argument type="service" id="httplug.message_factory"/>
         </service>
+        <service id="httplug.factory.symfony" class="Http\HttplugBundle\ClientFactory\SymfonyFactory" public="false">
+            <argument type="service" id="httplug.psr17_response_factory"/>
+            <argument type="service" id="httplug.psr17_stream_factory"/>
+        </service>
     </services>
 </container>

tests/Unit/ClientFactory/SymfonyFactoryTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
+
+use Http\HttplugBundle\ClientFactory\SymfonyFactory;
+use PHPUnit\Framework\TestCase;
+use Psr\Http\Message\ResponseFactoryInterface;
+use Psr\Http\Message\StreamFactoryInterface;
+use Symfony\Component\HttpClient\HttplugClient;
+
+/**
+ * @author Tobias Nyholm <tobias.nyholm@gmail.com>
+ */
+class SymfonyFactoryTest extends TestCase
+{
+    public function testCreateClient(): void
+    {
+        if (!class_exists(HttplugClient::class)) {
+            $this->markTestSkipped('Symfony Http client is not installed');
+        }
+
+        $factory = new SymfonyFactory(
+            $this->getMockBuilder(ResponseFactoryInterface::class)->getMock(),
+            $this->getMockBuilder(StreamFactoryInterface::class)->getMock()
+        );
+        $client = $factory->createClient();
+
+        $this->assertInstanceOf(HttplugClient::class, $client);
+    }
+}