Skip to content

Commit cf01068

Browse files
committed
Fixing risky tests
Makring tests that have no assertions with the annotation to suppress phpunits warning around risky tests closes 1370
1 parent d1dfe04 commit cf01068

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

Tests/JsonSerializerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ public function testShouldImplementSerializerInterface()
1717
$this->assertClassImplements(Serializer::class, JsonSerializer::class);
1818
}
1919

20+
/**
21+
* @doesNotPerformAssertions
22+
*/
2023
public function testCouldBeConstructedWithoutAnyArguments()
2124
{
2225
new JsonSerializer();

Tests/RdKafkaConsumerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
class RdKafkaConsumerTest extends TestCase
1515
{
16+
/**
17+
* @doesNotPerformAssertions
18+
*/
1619
public function testCouldBeConstructedWithRequiredArguments()
1720
{
1821
new RdKafkaConsumer(

Tests/RdKafkaProducerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717

1818
class RdKafkaProducerTest extends TestCase
1919
{
20+
/**
21+
* @doesNotPerformAssertions
22+
*/
2023
public function testCouldBeConstructedWithKafkaProducerAndSerializerAsArguments()
2124
{
2225
new RdKafkaProducer($this->createKafkaProducerMock(), $this->createSerializerMock());

0 commit comments

Comments
 (0)